search

overhangio / tutor-mfe

This plugin makes it possible to easily add micro frontend (MFE) applications on top of an Open edX platform that runs with Tutor.
GNU Affero General Public License v3.0
22 stars 95 forks source link

Add "nightly" suffix to the tutor dependency version #43

Closed 0x29a closed 2 years ago

0x29a commented 2 years ago

I was following Installing Tutor Nightly documentation page, and realized that tutor config printvalue OPENEDX_COMMON_VERSION yields maple.2 instead of master.

It appeared that pip install -e ./tutor-mfe step uninstalls nightly version of tutor and installs it from PyPi:

Installing collected packages: tutor, tutor-mfe
  Attempting uninstall: tutor
    Found existing installation: tutor 13.1.8-nightly
    Uninstalling tutor-13.1.8-nightly:
      Successfully uninstalled tutor-13.1.8-nightly
  Running setup.py develop for tutor-mfe
Successfully installed tutor-13.1.8 tutor-mfe

This PR is adding nighly suffix to the tutor version. As a result, the package won't uninstall nighly version, but alone still will install the correct version from PyPi.

regisb commented 2 years ago

Hi @0x29a! You're right that this is a bug, but the right fix is actually to modify the version of the tutor package. The problem was reported a couple days ago and I proposed a fix here: https://github.com/overhangio/tutor/pull/618 I'll merge it right now. If it resolves your problem, please close this PR.

0x29a commented 2 years ago

Thank you, @regisb, this resolves the problem.