overhangio / tutor-mfe

This plugin makes it possible to easily add micro frontend (MFE) applications on top of an Open edX platform that runs with Tutor.
GNU Affero General Public License v3.0
22 stars 95 forks source link

Fix (build): use NPM_REGISTRY from the config #75

Closed ARMBouhali closed 2 years ago

ARMBouhali commented 2 years ago

TL;DR - Use the NPM_REGISTRY config in Dockerfile, the same way it's done in other Tutor Dockerfiles (tutor-discovery, tutor-ecommerce, tutor:openedx, tutor-contrib-credentials).

We just replace the default registry URL with the config NPM_REGISTRY which defaults to the same value.

This is required in order to use a custom registry either for caching or for accessing private packages.

Testing I've been using that fix for a while. I'm currently surviving long repetitive downloads thanks to my local pull-through cache NPM registry powered by Verdaccio.

FYI @arbrandes @regisb