overhangio / tutor

The Docker-based Open edX distribution designed for peace of mind
https://docs.tutor.overhang.io/
GNU Affero General Public License v3.0
936 stars 443 forks source link

Mounting all MFEs leads to error #1167

Open CodeWithEmad opened 3 days ago

CodeWithEmad commented 3 days ago

After mounting all MFEs, there will be no ports left in the mfe service Screenshot from 2024-11-26 11-13-12

and dev fails to start:

tutor dev start    
docker compose -f /home/emad/redwood.3/tutor/env/local/docker-compose.yml -f /home/emad/redwood.3/tutor/env/local/docker-compose.prod.yml --project-name tutor_local stop
docker compose -f /home/emad/redwood.3/tutor/env/local/docker-compose.yml -f /home/emad/redwood.3/tutor/env/dev/docker-compose.yml --project-name tutor_dev up --remove-orphans
services.mfe.ports must be a list
Error: Command failed with status 15: docker compose -f /home/emad/redwood.3/tutor/env/local/docker-compose.yml -f /home/emad/redwood.3/tutor/env/dev/docker-compose.yml --project-name tutor_dev up --remove-orphans
regisb commented 3 days ago

Ha! That's unexpected. Do you want to propose a fix? In my opinion the only proper solution is to create a dedicated iter_mfe_exposes_ports(MOUNTS) template filter.

CodeWithEmad commented 2 days ago

I don’t have an answer readily available right now. Feel free to proceed if you have a suggestion.