overkill32 / hassio-remote-backup

Automatically create Hass.io snapshots to remote server location.
MIT License
71 stars 26 forks source link

Feature Request / keep_remote_backup #14

Open mjoshd opened 5 years ago

mjoshd commented 5 years ago

It would make this addon perfect if it could preserve a specified number of remote backups in the same way that it can preserve a specified number of local backups.

NixBiks commented 5 years ago

I’d add that functionality on the remote server side rather than on this add on. I don’t like giving the user right to delete on the remote server. Is that just me?

mjoshd commented 5 years ago

That is a valid point of view.

As I see it though, the uploaded files are owned by the user that uploaded them and the user should have rights to remove their own files unless explicitly denied. Not saying it is the right way but that's my view.

For example, how would you feel if your favorite offsite backup provider let you programmatically upload backups but never let you delete any to make space for new files and had no failover like a rollover policy where oldest backup gets automatically removed to make space for newer ones unless specially tagged for archival.

Unless you actively go into the system and remove old/unnecessary backups you will inevitably run out of storage space and your automatic backups will cease to copy.... at which point, why have a backup system that automatically copies them to a safe location?

Besides, the addon already has the keep_local_backup capabilities on the backup directory so I don't see how it is any different... still an automated actor cleaning up old files.

Again, not saying my way of thinking is correct, just explaining my view. 😃

swordh commented 5 years ago

I would really like this feature, was about to propose it when I saw this request.

I’d add that functionality on the remote server side rather than on this add on. I don’t like giving the user right to delete on the remote server. Is that just me?

A backup software always has a retention policy to not fill up all the space on the storage. From a administrative point of view this will be easier to have it all in one place. Also, you wouldn't give the use permissions to delete anything (the user probably already has admin rights on the remote server anyway), the addon would only delete files that matches the naming convention in the remote folder. And I think everyone who uses the addon are going to use a separate folder for backups, so any wrongfully deletions would be very slim.

pho3nixf1re commented 4 years ago

In my case I use Couchdrop.io and thus do not have a server to add this rolling functionality to. I agree this should at least be an option as currently I have to manually log in and remove these periodically.