Enhance Testing Coverage for Chainlink Feeds and Factory

overlay-market / v1-core

Core smart contracts of Overlay V1

MIT License

41 stars 13 forks source link

Enhance Testing Coverage for Chainlink Feeds and Factory #151

Open TomasCImach opened 9 months ago

TomasCImach commented 9 months ago

          The changes proposed here tests the cases with an already deployed feed factory and feed. While this is very helpful and enable us to test on Arbitrum mainnet environment with the actual feeds that we're using, it will not catch the future changes made on chainlink feeds and fatory.

We should add test-deployed feeds as well. @EperezOk @magnetto90 please comment on this.

_Originally posted by @TomasCImach in https://github.com/overlay-market/v1-core/pull/133#discussion_r1455877319_

EperezOk commented 9 months ago

If we are going to write new tests, I think we should do that in Foundry. However, unless we plan on making changes to the feeds/factory, I don't think this is a priority right now.