search

overleaf / spelling

The backend spellcheck API that performs spell checking for Overleaf
GNU Affero General Public License v3.0
9 stars 17 forks source link

Update OError to v3 #57

Closed mserranom closed 4 years ago

mserranom commented 4 years ago

Description

Updates the service to use OError v3.

Before merging we need to update logger-sharelatex module compatibility with OError v3.

Review

Potential Impact

Logging and error recovery scenarios.

Manual Testing Performed

Who Needs to Know?

@jdleesmiller @warncke

jdleesmiller commented 4 years ago

@mserranom it looks like there's build failure (just linting)

mserranom commented 4 years ago

Yeah, build has been broken in master for a while: https://console.cloud.google.com/cloud-build/builds/4e28d062-09a4-4fc7-83dc-53c40d16ac9e?project=overleaf-ops

I'll fix format and linting separately and rebase before removing the draft status.

mserranom commented 4 years ago

Closing in favour of https://github.com/overleaf/spelling/pull/59