[SpellingAPIManager] get the list of ignored misspellings from settings - Githubissues

overleaf / spelling

The backend spellcheck API that performs spell checking for Overleaf

GNU Affero General Public License v3.0

9 stars 17 forks source link

[SpellingAPIManager] get the list of ignored misspellings from settings #74

Closed das7pad closed 4 years ago

das7pad commented 4 years ago

Description

For https://github.com/overleaf/issues/issues/3454

This PR allows us to insert not-so correct words like COVID into the ignored misspellings w/o impacting hosted versions.

Related Issues / PRs

https://github.com/overleaf/issues/issues/3454

Potential Impact

High. The ignored misspellings array is accessed on every spell check request. There are acceptance tests to cover the code path.

Manual Testing Performed

add custom env var in the dev-env

diff --git a/docker-compose.yml b/docker-compose.yml
index bfe2d3c7a..4f6e26264 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -258,0 +259,2 @@ services:
+    environment:
+      IGNORED_MISSPELLINGS: 'COVID,ShareLaTeX'

start core + spelling: dev-env$ bin/up core spelling
write COVID and another misspelled word -- only the other word should get marked as misspelled

Deployment Checklist

[ ] merge google-ops PR https://github.com/overleaf/google-ops/pull/1296