Provide fallback to ShareLaTeX branded rc entry in 4.x setups

overleaf / toolkit

GNU Affero General Public License v3.0

510 stars 122 forks source link

Provide fallback to ShareLaTeX branded rc entry in 4.x setups #221

Closed das7pad closed 4 months ago

das7pad commented 4 months ago

Description

Small fix for https://github.com/overleaf/toolkit/pull/217

The rc file has the old branding on the core variables SHARELATEX_LISTEN_IP and SHARELATEX_PORT. After rebanding the rc entry we still need to fallback to the old ones for customers using the latest toolkit version with a 4.x release.

Related issues / Pull Requests

For https://github.com/overleaf/toolkit/pull/217

Contributor Agreement

[x] I confirm I have signed the Contributor License Agreement

mserranom commented 4 months ago

I was planning to tweak the update scripts to force customers to upgrade config/overleaf.rc on bin/upgrade, regardless of the value of config/version.

I think this is a better option. And we can still tweak it to recommend the upgrade after pulling with bin/upgrade.

das7pad commented 4 months ago

Yeah, ideally we can separate upgrading the toolkit from upgrading Server Pro. This is especially useful for customers on very old versions (of the toolkit/Server Pro), e.g. before we added MONGO_IMAGE, so they can use bin/upgrade without confirming the version prompt, upgrade mongo, then upgrade the Server Pro version step wise, until finally running bin/upgrade again and pulling in the latest Server Pro version.

das7pad commented 4 months ago

Feel free to merge this into your integration branch #217