search

overleaf / toolkit

GNU Affero General Public License v3.0
633 stars 152 forks source link

Can not recognize OVERLEAF_IMAGE_NAME #251

Open wang-tf opened 6 months ago

wang-tf commented 6 months ago

Steps to Reproduce

  1. bin/init
  2. Uncomment the OVERLEAF_IMAGE_NAME variable to use a user-defined image
  3. bin/up

Expected Behaviour

Using defined sharelatex version image.

Observed Behaviour

Error response from daemon: invalid reference format

Context

Technical Info

Analysis

Replacing IMAGE using OVERLEAF_IMAGE_NAME in lib/docker-compose.base.yml.

rscmendes commented 1 month ago

Had the same issue. A temporary workaround is to change line 87 of bin/docker-compose to export IMAGE="$image_name"

The problem is that this script appends the contents of config/version to the image, such that if we use a custom image we will have duplicated tag such as sharelatex/sharelatex/my_custom_tag/5.1.1 which results in the error.

The permanent fix for this should be simply to parse $image_name, and append only the contents of config/version if it does not yet contain a tag. However, it should be tested if this would break the download/update, so I leave this for the experts.

dangdd2003 commented 1 month ago

Same issue with me when i tried to create new image for overleaf and defined it here, but that file config/version only accept two value 5.1.1 and 5.1.1-with-texlive-full. As i know, that version file is the tag of defined overleaf image in overleaf.rc. Even though i changed tag (value in version file) to match with my created overleaf image, it did not work. There has been conflict between user defined image value and version file that makes this option really really useless. Please remove or fix if it can not work properly.

phoenixbf commented 4 weeks ago

same issue. Solved with workaround in bin/docker-compose