overleaf / toolkit

GNU Affero General Public License v3.0
576 stars 138 forks source link

bin/up: pull TeX Live images before starting up #258

Closed das7pad closed 4 months ago

das7pad commented 4 months ago

Description

Part of https://github.com/overleaf/internal/issues/17497 Sibling for https://github.com/overleaf/internal/pull/18523

This PR is adding a startup step in bin/up to pull TeXLive images ahead of recreating/starting the container.

This will avoid the need to warn customers about compiles being unavailable for a while when enabling sandboxed compiles. cc @mlevans0

toolkit$ bin/up sharelatex
Initiating Mongo replica set...
[+] Running 1/0
 ✔ Container mongo  Running                                                                                                                                                                                                                                                          0.0s 

Please configure ALL_TEX_LIVE_DOCKER_IMAGES in /code/overleaf/toolkit/config/variables.env

You can read more about configuring Sandboxed Compiles in our documentation:
  https://github.com/overleaf/overleaf/wiki/Server-Pro:-sandboxed-compiles#changing-the-texlive-image

toolkit$  echo $?
1 
toolkit$ bin/up --dry-run sharelatex
Initiating Mongo replica set...
[+] Running 1/0
 ✔ Container mongo  Running                                                                                                                                                                                                                                                          0.0s 
Pulling TeX Live images...
  - quay.io/sharelatex/texlive-full:2022.1 download started (may take some time)
2022.1: Pulling from sharelatex/texlive-full
Digest: sha256:4cc4060337c756c8df8f7b74e1138eebf557a68db70a57e222ccc808e2b4ab64
Status: Image is up to date for quay.io/sharelatex/texlive-full:2022.1
quay.io/sharelatex/texlive-full:2022.1
  - quay.io/sharelatex/texlive-full:2022.1 download finished
  - quay.io/sharelatex/texlive-full:2023.1 download started (may take some time)
2023.1: Pulling from sharelatex/texlive-full
Digest: sha256:395a3d79f858ace6fcbea1b4cfa5be343591413a1c4de01d8d329ed7389f455b
Status: Image is up to date for quay.io/sharelatex/texlive-full:2023.1
quay.io/sharelatex/texlive-full:2023.1
  - quay.io/sharelatex/texlive-full:2023.1 download finished
[+] Running 3/0
 ✔ DRY-RUN MODE -  Container mongo       Running
...

Related issues / Pull Requests

Part of https://github.com/overleaf/internal/issues/17497 Sibling for https://github.com/overleaf/internal/pull/18523

Contributor Agreement

Manual testing performed