search

overmindbots / core

Core monorepo with our apps and packages
1 stars 0 forks source link

Request retries could go on forever #97

Closed RafaelVidaurre closed 6 years ago

RafaelVidaurre commented 6 years ago

The current logic is that if a fetchInvites request throws an error that is not 50013 we retry it. This could lead for things like rate limit errors or other unexpected errors to loop infinitely requesting forever.

I'd make the conditions for retrying more precise. Or add a max amount of subsequent retries

RafaelVidaurre commented 6 years ago

Closing in favor of different approach