search

overmindtech / sdp-js

Javascript and Typescript libraries for the SDP protocol
Other
0 stars 0 forks source link

Add `QueryStatus` messages to tracking in `RequestProgress` #89

Closed dylanratcliffe closed 1 year ago

dylanratcliffe commented 1 year ago

We now have very nice query status updates,, we should be tracking them here:

https://github.com/overmindtech/sdp-js/blob/927fe8a5bd8e1c3fcd44911e8473577a4176b57b/src/request-progress.ts#L4

This will help with: https://github.com/overmindtech/frontend/issues/77

dylanratcliffe commented 1 year ago

The use case for this at the moment is being able to show a spinner that there are some queries still running, the designs aren't more detailed than that so that would be a good starting point

dylanratcliffe commented 1 year ago

@getinnocuous As decided in standup, it'll be better to implement this as an event listener in React. The StatusEvent already exists, and you should be able to use the same logic as I did to check if anything is running:

const queriesRunning = (this.status.summary?.working || 0) > 0