search

overmindtech / sdp

Protobuf based protocol for describing the state of a system
Other
4 stars 1 forks source link

feat: add risks to ChangeSummary #152

Closed getinnocuous closed 11 months ago

getinnocuous commented 11 months ago

Currently the /changes page data is populated by ChangesSummary and not Changes. This PR adds the risks to summary so that the UI can reflect the new designs.

getinnocuous commented 11 months ago

yes, its on the change so that will be sufficient

What changed since yesterday?

The /changes page actually uses the type ChangesSummary to populate it's data.

DavidS-ovm commented 11 months ago

The ChangeSummary is also used in ListHomeChangesResponse, so adding the risks here will load a bunch of data on the home screen that's not used there.

On the other hand, the change detail screen already does a second call to load additional data (GetChangeTimeline). Maybe it's time to create a GetChangeDetails that loads everything in one swoop for that screen?

The Change detail screen already loads the full change to display the health status, it shouldn't also load a ChangeSummary.