overtake / TelegramSwift

Source code of Telegram for macos on Swift 5.0
https://macos.telegram.org
GNU General Public License v2.0
5.06k stars 856 forks source link

An option to disable emoji suggestions #293

Open hatarist opened 5 years ago

hatarist commented 5 years ago

It was added recently and is a bit of pain in the ass for some people. For example, the ":3" smiley is pretty popular among my Russian social circle, I use it oftentimes. If I type a - certainly meaningless, but still - message that contains just a ":3", it shows a " 3️⃣" emoji in the suggestion bar above the message field. If I hit Enter, the ":3" will be replaced with the " 3️⃣".

It also suggests emojis on some popular words like "hi", "thanks" or whatever else; it distracts a little, too.

I'd really appreciate an option to turn the suggestions off; just like we already do have an option to "automatically replace emojis"

yhaskell commented 5 years ago

An alternative would be to atleast not select any emoji by default when you type a colon. That is very annoying -- let it show me emoji but let me press enter and send my colon without automatically put 😍emoji in my work chat.

Drakal commented 5 years ago

This is a feature on the Windows/Linux/Old Mac version of the app, it is very confusing that this newer Mac version lacks this important option, this should be implemented immediately to maintain feature parity.

Drakal commented 5 years ago

Actually the feature looks to be in the app already, but some lunatic had it be disabled under indecipherable conditions! Screw it, make it always visible, wtf is the dev thinking?

306

yhaskell commented 5 years ago

As much as I understand the sentiment, calling people lunatics is probably not the best way to behave in public. Also not productive

CallumBee commented 5 years ago

I think the answer to this would be to allow people to map their own or also the change a default mapping to what suits them. For example I use XD and xD a lot but comes out at 😆 and 😂 respectively which isn't what I mean by them! So being able to delete those mappings but keep the others - Which I do find helpful.

josh-berry commented 5 years ago

This feature also causes problems with keyboard editing of a draft message. For example (in Telegram 5.7 (181163) AppStore):

  1. Type "Hi htere :3" into the message field
  2. Realize you made a typo ("htere")
  3. Hit the left arrow key repeatedly to go back to fix the typo
  4. Keep hitting the left arrow key for a while until you realize the cursor isn't actually moving because the emoji suggestion box has appeared
  5. Hit "Esc" (while cursing under your breath in your preferred language) to get the #%&* thing to go away
  6. Actually fix the typo

One alternative to providing an option to get rid of it might be to require the user to press a key or key combo (e.g. Up or Cmd+Up) to explicitly switch focus to the suggestion box. That would at least make it less obtrusive or likely to interfere with normal editing operations.

matthewmorek commented 4 years ago

I'd like to plug in, as this relates to an issue I've been experiencing for the last two weeks or so when using traditional emoticons, i.e: :), ;), :P, :D, etc.

Issue

The above emoticons used to be automatically replaced by relevant emojis, when I finish typing (sort of like in Slack). As of a few updates ago they are not, and the settings are nowhere in the "General" section where they used to be.

Instead, I'm getting an emoji picker, but once I continue typing past the colon it disappears and nothing gets replaced.

Expected result

Hey! This is awesome! 😄

What actually happens

Hey! This is awesome! :D

Is this the intended behaviour, or is it a regression? Because this used to work perfectly and now it does not. I'm on 5.9.3 (191685) Beta.

CallumBee commented 4 years ago

I'd like to plug in, as this relates to an issue I've been experiencing for the last two weeks or so when using traditional emoticons, i.e: :), ;), :P, :D, etc.

Issue

The above emoticons used to be automatically replaced by relevant emojis, when I finish typing (sort of like in Slack). As of a few updates ago they are not, and the settings are nowhere in the "General" section where they used to be.

Instead, I'm getting an emoji picker, but once I continue typing past the colon it disappears and nothing gets replaced.

Expected result

Hey! This is awesome! 😄

What actually happens

Hey! This is awesome! :D

Is this the intended behaviour, or is it a regression? Because this used to work perfectly and now it does not. I'm on 5.9.3 (191685) Beta.

Sadly this is now a feature... Instead of making it something you could turn off they have done the cheap thing and remove it. Now being recommended changing and adding in MacOS shortcuts to give back this functionality! That isn't a fix it's a dirty dirty hack as it then effects every other program on your Mac and something you shouldn't have to do to get a feature that's on just about every other IM program.

zweeltow commented 4 years ago

Fixed i guess.

Settings > General > Emoji & Stickers.

image

matthewmorek commented 4 years ago

@zweeltow Not exactly. This is incomplete, as it only replaces emotes with emojis upon sending the message, not upon typing it out and proceeding to the next chunk of text (whether by adding punctuation, a space, or sending a message).

josh-berry commented 4 years ago

@zweeltow I think you're confusing two different things here:

  1. Replace emoji automatically (so ":)" becomes "😄")
  2. Showing a UI popup with emoji suggestions on what to replace

This issue is about the second of these two things, not the first. The OP even says [emphasis added]:

I'd really appreciate an option to turn the suggestions off; just like we already do have an option to "automatically replace emojis"

Drakal commented 4 years ago

Basically, pressing enter at the end of a message that ends in a typed emote should just send the message as is, not replace that emote with the first suggested emoji.

Current workaround for this bug is to create a habit of pressing space before enter.

On Fri, May 22, 2020 at 3:06 PM, Josh Berry notifications@github.com wrote:

@zweeltow I think you're confusing two different things here:

  • Replace emoji automatically (so ":)" becomes "😄")
  • Showing a UI popup with emoji suggestions on what to replace

This issue is about the second of these two things, not the first. The OP even says [emphasis added]:

I'd really appreciate an option to turn the suggestions off; just like we already do have an option to "automatically replace emojis"

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

PeterHeja commented 3 years ago

I just want to bump this, as I've run into @josh-berry 's (https://github.com/overtake/TelegramSwift/issues/293#issuecomment-530618894) problem multiple times under a minute moments ago, and I just don't think disabling a feature that actually can make user experience worse should be impossible.

dannote commented 3 years ago

Can they be disabled, at least when I intend to write a chunk of monospaced code after backtick? This is exceedingly terrible when I write in Ruby or Elixir, where semicolons are widely used.

ybizeul commented 3 years ago

I don't understand this issue doesn't have more traction. It is quite infuriating to type a colon then return just to find yourself self greeted with a 👍

piratrik commented 3 years ago

I'm here to add that I'm also so frustrated about this emoji suggestion bar for the exact same reason as @josh-berry @PeterHeja and @ybizeul.

That bar ruins productivity and is super frustrating. Please let us be able to disable it.

ppbdrinker commented 2 years ago

It is indeed somewhat aggravating to see emoticon hints that can't be turned off.

Not every telegram user is willing communicate with their peers using thumbnails. Humanity has invented alphabets that are encouraged to be used to construct words and sentences.

d8vjork commented 2 years ago

This will be cool but I always use it, tho in the last update of Telegram Swift is being showing wrong suggestions and being super slow to refresh the majority of time