daleglass
commented
3 months ago Here's what remains for me after this one:
/home/dale/git/overte/libraries/octree/src/OctreePacketData.cpp: In static member function ‘static int OctreePacketData::unpackDataFromBytes(const unsigned char*, AACube&)’:
/home/dale/git/overte/libraries/octree/src/OctreePacketData.cpp:816:11: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘struct aaCubeData’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
816 | memcpy(&cube, dataBytes, sizeof(aaCubeData));
| ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/dale/git/overte/libraries/octree/src/OctreePacketData.cpp:29:8: note: ‘struct aaCubeData’ declared here
29 | struct aaCubeData {
| ^~~~~~~~~~
[ 32%] Built target octree
/home/dale/git/overte/libraries/script-engine/src/ScriptManager.cpp: In member function ‘void ScriptManager::waitTillDoneRunning(bool)’:
/home/dale/git/overte/libraries/script-engine/src/ScriptManager.cpp:484:18: warning: unused variable ‘elapsedUsecs’ [-Wunused-variable]
484 | auto elapsedUsecs = usecTimestampNow() - startedWaiting;
| ^~~~~~~~~~~~
/home/dale/git/overte/libraries/script-engine/src/v8/ScriptObjectV8Proxy.cpp: In member function ‘virtual int ScriptSignalV8Proxy::qt_metacall(QMetaObject::Call, int, void**)’:
/home/dale/git/overte/libraries/script-engine/src/v8/ScriptObjectV8Proxy.cpp:1312:31: warning: ignoring return value of ‘v8::MaybeLocal<v8::Value> v8::Function::Call(v8::Local<v8::Context>, v8::Local<v8::Value>, int, v8::Local<v8::Value>*)’, declared with attribute ‘warn_unused_result’ [-Wunused-result]
1312 | callback->Call(functionContext, v8This, numArgs, args);
| ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/dale/overte-files/vcpkg/330a9219/installed/x64-linux/include/node/v8.h:33,
from /home/dale/git/overte/libraries/script-engine/src/v8/ScriptEngineV8.h:36,
from /home/dale/git/overte/libraries/script-engine/src/v8/ScriptObjectV8Proxy.h:28,
from /home/dale/git/overte/libraries/script-engine/src/v8/ScriptObjectV8Proxy.cpp:15:
/home/dale/overte-files/vcpkg/330a9219/installed/x64-linux/include/node/v8-function.h:55:43: note: declared here
55 | V8_WARN_UNUSED_RESULT MaybeLocal<Value> Call(Local<Context> context,
| ^~~~
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp: In constructor ‘RecordingScriptingInterface::RecordingScriptingInterface()’:
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:41:11: warning: unnecessary parentheses in declaration of ‘_mutex’ [-Wparentheses]
41 | Locker(_mutex);
| ^~~~~~~~
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:41:11: note: remove parentheses
41 | Locker(_mutex);
| ^~~~~~~~
| - -
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp: In member function ‘bool RecordingScriptingInterface::isPlaying() const’:
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:47:11: warning: unnecessary parentheses in declaration of ‘_mutex’ [-Wparentheses]
47 | Locker(_mutex);
| ^~~~~~~~
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:47:11: note: remove parentheses
47 | Locker(_mutex);
| ^~~~~~~~
| - -
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp: In member function ‘bool RecordingScriptingInterface::isPaused() const’:
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:52:11: warning: unnecessary parentheses in declaration of ‘_mutex’ [-Wparentheses]
52 | Locker(_mutex);
| ^~~~~~~~
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:52:11: note: remove parentheses
52 | Locker(_mutex);
| ^~~~~~~~
| - -
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp: In member function ‘float RecordingScriptingInterface::playerElapsed() const’:
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:57:11: warning: unnecessary parentheses in declaration of ‘_mutex’ [-Wparentheses]
57 | Locker(_mutex);
| ^~~~~~~~
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:57:11: note: remove parentheses
57 | Locker(_mutex);
| ^~~~~~~~
| - -
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp: In member function ‘float RecordingScriptingInterface::playerLength() const’:
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:62:11: warning: unnecessary parentheses in declaration of ‘_mutex’ [-Wparentheses]
62 | Locker(_mutex);
| ^~~~~~~~
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:62:11: note: remove parentheses
62 | Locker(_mutex);
| ^~~~~~~~
| - -
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp: In member function ‘void RecordingScriptingInterface::playClip(recording::NetworkClipLoaderPointer, const QString&, const ScriptValue&)’:
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:67:11: warning: unnecessary parentheses in declaration of ‘_mutex’ [-Wparentheses]
67 | Locker(_mutex);
| ^~~~~~~~
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:67:11: note: remove parentheses
67 | Locker(_mutex);
| ^~~~~~~~
| - -
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp: In member function ‘void RecordingScriptingInterface::loadRecording(const QString&, const ScriptValue&)’:
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:78:11: warning: unnecessary parentheses in declaration of ‘_mutex’ [-Wparentheses]
78 | Locker(_mutex);
| ^~~~~~~~
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:78:11: note: remove parentheses
78 | Locker(_mutex);
| ^~~~~~~~
| - -
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp: In member function ‘void RecordingScriptingInterface::startPlaying()’:
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:137:11: warning: unnecessary parentheses in declaration of ‘_mutex’ [-Wparentheses]
137 | Locker(_mutex);
| ^~~~~~~~
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:137:11: note: remove parentheses
137 | Locker(_mutex);
| ^~~~~~~~
| - -
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp: In member function ‘void RecordingScriptingInterface::setPlayerVolume(float)’:
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:142:11: warning: unnecessary parentheses in declaration of ‘_mutex’ [-Wparentheses]
142 | Locker(_mutex);
| ^~~~~~~~
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:142:11: note: remove parentheses
142 | Locker(_mutex);
| ^~~~~~~~
| - -
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp: In member function ‘void RecordingScriptingInterface::setPlayerTime(float)’:
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:156:11: warning: unnecessary parentheses in declaration of ‘_mutex’ [-Wparentheses]
156 | Locker(_mutex);
| ^~~~~~~~
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:156:11: note: remove parentheses
156 | Locker(_mutex);
| ^~~~~~~~
| - -
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp: In member function ‘void RecordingScriptingInterface::setPlayerLoop(bool)’:
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:165:11: warning: unnecessary parentheses in declaration of ‘_mutex’ [-Wparentheses]
165 | Locker(_mutex);
| ^~~~~~~~
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:165:11: note: remove parentheses
165 | Locker(_mutex);
| ^~~~~~~~
| - -
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp: In member function ‘void RecordingScriptingInterface::pausePlayer()’:
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:186:11: warning: unnecessary parentheses in declaration of ‘_mutex’ [-Wparentheses]
186 | Locker(_mutex);
| ^~~~~~~~
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:186:11: note: remove parentheses
186 | Locker(_mutex);
| ^~~~~~~~
| - -
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp: In member function ‘void RecordingScriptingInterface::stopPlaying()’:
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:196:11: warning: unnecessary parentheses in declaration of ‘_mutex’ [-Wparentheses]
196 | Locker(_mutex);
| ^~~~~~~~
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:196:11: note: remove parentheses
196 | Locker(_mutex);
| ^~~~~~~~
| - -
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp: In member function ‘void RecordingScriptingInterface::startRecording()’:
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:214:11: warning: unnecessary parentheses in declaration of ‘_mutex’ [-Wparentheses]
214 | Locker(_mutex);
| ^~~~~~~~
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:214:11: note: remove parentheses
214 | Locker(_mutex);
| ^~~~~~~~
| - -
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp: In member function ‘void RecordingScriptingInterface::stopRecording()’:
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:224:11: warning: unnecessary parentheses in declaration of ‘_mutex’ [-Wparentheses]
224 | Locker(_mutex);
| ^~~~~~~~
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:224:11: note: remove parentheses
224 | Locker(_mutex);
| ^~~~~~~~
| - -
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp: In member function ‘void RecordingScriptingInterface::saveRecording(const QString&)’:
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:239:11: warning: unnecessary parentheses in declaration of ‘_mutex’ [-Wparentheses]
239 | Locker(_mutex);
| ^~~~~~~~
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:239:11: note: remove parentheses
239 | Locker(_mutex);
| ^~~~~~~~
| - -
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp: In member function ‘bool RecordingScriptingInterface::saveRecordingToAsset(const ScriptValue&)’:
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:254:11: warning: unnecessary parentheses in declaration of ‘_mutex’ [-Wparentheses]
254 | Locker(_mutex);
| ^~~~~~~~
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:254:11: note: remove parentheses
254 | Locker(_mutex);
| ^~~~~~~~
| - -
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp: In member function ‘void RecordingScriptingInterface::loadLastRecording()’:
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:296:11: warning: unnecessary parentheses in declaration of ‘_mutex’ [-Wparentheses]
296 | Locker(_mutex);
| ^~~~~~~~
/home/dale/git/overte/libraries/recording/src/recording/RecordingScriptingInterface.cpp:296:11: note: remove parentheses
296 | Locker(_mutex);
| ^~~~~~~~
| - -
/home/dale/git/overte/libraries/gpu/src/gpu/Texture_ktx.cpp: In member function ‘bool GPUKTXPayload::unserialize(const gpu::Byte*, size_t)’:
/home/dale/git/overte/libraries/gpu/src/gpu/Texture_ktx.cpp:77:15: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘class gpu::Sampler::Desc’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
77 | memcpy(&_samplerDesc, data, sizeof(Sampler::Desc));
| ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/dale/git/overte/libraries/gpu/src/gpu/Texture_ktx.cpp:13:
/home/dale/git/overte/libraries/gpu/src/gpu/Texture.h:128:11: note: ‘class gpu::Sampler::Desc’ declared here
128 | class Desc {
| ^~~~
/home/dale/git/overte/libraries/gpu/src/gpu/Texture_ktx.cpp:91:19: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘glm::ivec2’ {aka ‘struct glm::vec<2, int, glm::packed_highp>’} with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
91 | memcpy(&_originalSize, data, sizeof(glm::ivec2));
| ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/dale/overte-files/vcpkg/330a9219/installed/x64-linux/include/glm/ext/vector_bool2.hpp:5,
from /home/dale/overte-files/vcpkg/330a9219/installed/x64-linux/include/glm/vec2.hpp:5,
from /home/dale/overte-files/vcpkg/330a9219/installed/x64-linux/include/glm/glm.hpp:116,
from /home/dale/git/overte/libraries/shared/src/RegisteredMetaTypes.h:20,
from /home/dale/git/overte/libraries/gpu/src/gpu/Texture.h:23:
/home/dale/overte-files/vcpkg/330a9219/installed/x64-linux/include/glm/detail/type_vec2.hpp:17:16: note: ‘glm::ivec2’ {aka ‘struct glm::vec<2, int, glm::packed_highp>’} declared here
17 | struct vec<2, T, Q>
| ^~~~~~~~~~~~
/home/dale/git/overte/libraries/gpu/src/gpu/Texture_ktx.cpp: In member function ‘bool IrradianceKTXPayload::unserialize(const gpu::Byte*, size_t)’:
/home/dale/git/overte/libraries/gpu/src/gpu/Texture_ktx.cpp:147:15: warning: ‘void* memcpy(void*, const void*, size_t)’ writing to an object of type ‘class gpu::SphericalHarmonics’ with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
147 | memcpy(&_irradianceSH, data, sizeof(SphericalHarmonics));
| ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/dale/git/overte/libraries/gpu/src/gpu/Texture.h:59:7: note: ‘class gpu::SphericalHarmonics’ declared here
59 | class SphericalHarmonics {
| ^~~~~~~~~~~~~~~~~~
In file included from /home/dale/git/overte/libraries/render/src/render/Scene.h:16,
from /home/dale/git/overte/libraries/render/src/render/Engine.h:20,
from /home/dale/git/overte/libraries/render/src/render/FilterTask.h:15,
from /home/dale/git/overte/libraries/render/src/render/FilterTask.cpp:12:
In constructor ‘render::ItemBound::ItemBound(render::ItemBound&&)’,
inlined from ‘void std::__new_allocator<_Tp>::construct(_Up*, _Args&& ...) [with _Up = render::ItemBound; _Args = {render::ItemBound}; _Tp = render::ItemBound]’ at /usr/include/c++/14/bits/new_allocator.h:191:4,
inlined from ‘static void std::allocator_traits<std::allocator<_CharT> >::construct(allocator_type&, _Up*, _Args&& ...) [with _Up = render::ItemBound; _Args = {render::ItemBound}; _Tp = render::ItemBound]’ at /usr/include/c++/14/bits/alloc_traits.h:534:17,
inlined from ‘void std::vector<_Tp, _Alloc>::emplace_back(_Args&& ...) [with _Args = {render::ItemBound}; _Tp = render::ItemBound; _Alloc = std::allocator<render::ItemBound>]’ at /usr/include/c++/14/bits/vector.tcc:117:30,
inlined from ‘void render::IDsToBounds::run(const render::RenderContextPointer&, const render::ItemIDs&, render::ItemBounds&)’ at /home/dale/git/overte/libraries/render/src/render/FilterTask.cpp:142:38:
/home/dale/git/overte/libraries/render/src/render/Item.h:336:7: warning: ‘<unnamed>.render::ItemBound::padding’ may be used uninitialized [-Wmaybe-uninitialized]
336 | class ItemBound {
| ^~~~~~~~~
/home/dale/git/overte/libraries/render/src/render/FilterTask.cpp: In member function ‘void render::IDsToBounds::run(const render::RenderContextPointer&, const render::ItemIDs&, render::ItemBounds&)’:
/home/dale/git/overte/libraries/render/src/render/FilterTask.cpp:142:89: note: ‘<anonymous>’ declared here
142 | outItems.emplace_back(ItemBound{ id, item.getBound(renderContext->args) });
| ^
In file included from /home/dale/git/build-warnmaster/libraries/model-serializers/model-serializers_autogen/UVLADIE3JM/moc_GLTFSerializer.cpp:10,
from /home/dale/git/build-warnmaster/libraries/model-serializers/model-serializers_autogen/mocs_compilation.cpp:3:
/home/dale/git/build-warnmaster/libraries/model-serializers/model-serializers_autogen/UVLADIE3JM/../../../../../overte/libraries/model-serializers/src/GLTFSerializer.h:24:14: warning: ‘float atof_locale_independent(char*)’ defined but not used [-Wunused-function]
24 | static float atof_locale_independent(char *str) {
| ^~~~~~~~~~~~~~~~~~~~~~~
[ 61%] Linking CXX shared library libmodel-baker.so
[ 61%] Built target model-baker
/home/dale/git/overte/libraries/model-serializers/src/GLTFSerializer.cpp: In member function ‘void GLTFSerializer::setHFMMaterial(HFMMaterial&, const cgltf_material&)’:
/home/dale/git/overte/libraries/model-serializers/src/GLTFSerializer.cpp:1349:83: warning: comparison of integer expressions of different signedness: ‘int’ and ‘cgltf_size’ {aka ‘long unsigned int’} [-Wsign-compare]
1349 | if (object["index"].isDouble() && object["index"].toInt() < _data->textures_count) {
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
/home/dale/git/overte/libraries/model-serializers/src/GLTFSerializer.cpp:1358:83: warning: comparison of integer expressions of different signedness: ‘int’ and ‘cgltf_size’ {aka ‘long unsigned int’} [-Wsign-compare]
1358 | if (object["index"].isDouble() && object["index"].toInt() < _data->textures_count) {
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
/home/dale/git/overte/libraries/model-serializers/src/GLTFSerializer.cpp:1373:83: warning: comparison of integer expressions of different signedness: ‘int’ and ‘cgltf_size’ {aka ‘long unsigned int’} [-Wsign-compare]
1373 | if (object["index"].isDouble() && object["index"].toInt() < _data->textures_count) {
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
/home/dale/git/overte/libraries/model-serializers/src/GLTFSerializer.cpp:1391:83: warning: comparison of integer expressions of different signedness: ‘int’ and ‘cgltf_size’ {aka ‘long unsigned int’} [-Wsign-compare]
1391 | if (object["index"].isDouble() && object["index"].toInt() < _data->textures_count) {
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
/home/dale/git/overte/libraries/model-serializers/src/GLTFSerializer.cpp:1420:83: warning: comparison of integer expressions of different signedness: ‘int’ and ‘cgltf_size’ {aka ‘long unsigned int’} [-Wsign-compare]
1420 | if (object["index"].isDouble() && object["index"].toInt() < _data->textures_count) {
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
/home/dale/git/overte/libraries/model-serializers/src/GLTFSerializer.cpp: In instantiation of ‘bool findPointerInArray(const T*, const T*, size_t, int&) [with T = cgltf_node; size_t = long unsigned int]’:
/home/dale/git/overte/libraries/model-serializers/src/GLTFSerializer.cpp:191:36: required from here
191 | if (!findPointerInArray(child, _data->nodes, _data->nodes_count, childIndex)) {
| ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/dale/git/overte/libraries/model-serializers/src/GLTFSerializer.cpp:152:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
152 | for (int i = 0; i < arraySize; i++) {
| ~~^~~~~~~~~~~
/home/dale/git/overte/libraries/model-serializers/src/GLTFSerializer.cpp: In instantiation of ‘bool findPointerInArray(const T*, const T*, size_t, int&) [with T = cgltf_material; size_t = long unsigned int]’:
/home/dale/git/overte/libraries/model-serializers/src/GLTFSerializer.cpp:965:73: required from here
965 | if (primitive.material != nullptr && !findPointerInArray(primitive.material, _data->materials, _data->materials_count, materialIndex)) {
| ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/dale/git/overte/libraries/model-serializers/src/GLTFSerializer.cpp:152:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
152 | for (int i = 0; i < arraySize; i++) {
| ~~^~~~~~~~~~~
/home/dale/git/overte/libraries/model-serializers/src/GLTFSerializer.cpp: In instantiation of ‘bool findPointerInArray(const T*, const T*, size_t, int&) [with T = cgltf_image; size_t = long unsigned int]’:
/home/dale/git/overte/libraries/model-serializers/src/GLTFSerializer.cpp:1310:36: required from here
1310 | if (!findPointerInArray(image, _data->images, _data->images_count, imageIndex)) {
| ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/dale/git/overte/libraries/model-serializers/src/GLTFSerializer.cpp:152:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
152 | for (int i = 0; i < arraySize; i++) {
| ~~^~~~~~~~~~~
In file included from /home/dale/git/overte/libraries/model-networking/src/model-networking/ModelCache.cpp:29:
/home/dale/git/overte/libraries/model-serializers/src/GLTFSerializer.h:24:14: warning: ‘float atof_locale_independent(char*)’ defined but not used [-Wunused-function]
24 | static float atof_locale_independent(char *str) {
| ^~~~~~~~~~~~~~~~~~~~~~~
/home/dale/git/overte/libraries/render-utils/src/Model.cpp: In member function ‘virtual void Blender::run()’:
/home/dale/git/overte/libraries/render-utils/src/Model.cpp:1908:15: warning: ‘void* memset(void*, int, size_t)’ clearing an object of type ‘struct BlendshapeOffsetUnpacked’ with no trivial copy-assignment; use assignment or value-initialization instead [-Wclass-memaccess]
1908 | memset(unpackedBlendshapeOffsets.data(), 0, numVertsInMesh * sizeof(BlendshapeOffsetUnpacked));
| ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/dale/git/overte/libraries/render/src/render/Item.h:32,
from /home/dale/git/overte/libraries/render/src/render/Scene.h:16,
from /home/dale/git/overte/libraries/render-utils/src/Model.h:31,
from /home/dale/git/overte/libraries/render-utils/src/Model.cpp:12:
/home/dale/git/overte/libraries/shared/src/BlendshapeConstants.h:121:8: note: ‘struct BlendshapeOffsetUnpacked’ declared here
121 | struct BlendshapeOffsetUnpacked {
| ^~~~~~~~~~~~~~~~~~~~~~~~
per @daleglass's suggestion, this is cherry-picked from https://github.com/overte-org/overte/pull/938 to be against master instead of protocol_changes, with the "warnings as errors" flag turned off, so we can just get these small fixes in quicker
after merging this, I will merge master -> protocol_changes and rebase #938
no QA really needed, if it builds and looks good we can merge it
Funding
This project is funded through NGI0 Entrust, a fund established by NLnet with financial support from the European Commission's Next Generation Internet program. Learn more at the NLnet project page.