overte-org / overte

Overte open source virtual worlds platform.
https://overte.org/
Other
127 stars 47 forks source link

Build warnings in latest master #1012

Closed daleglass closed 2 weeks ago

daleglass commented 2 weeks ago
In file included from /usr/include/c++/14/cassert:44,
                 from /home/dale/git/overte/overte-master/libraries/shared/src/MovingMinMaxAvg.h:15,
                 from /home/dale/git/overte/overte-master/libraries/audio/src/InboundAudioStream.h:25,
                 from /home/dale/git/overte/overte-master/libraries/audio/src/MixedProcessedAudioStream.h:15,
                 from /home/dale/git/overte/overte-master/libraries/audio-client/src/AudioClient.h:40,
                 from /home/dale/git/overte/overte-master/interface/src/avatar/MyAvatar.cpp:34:
/home/dale/git/overte/overte-master/interface/src/avatar/MyAvatar.cpp: In member function ‘void MyAvatar::FollowHelper::deactivate(CharacterController::FollowType)’:
/home/dale/git/overte/overte-master/interface/src/avatar/MyAvatar.cpp:5771:22: warning: comparison is always true due to limited range of data type [-Wtype-limits]
 5771 |     assert((int)type >= 0 && (int)type < static_cast<int>(CharacterController::FollowType::Count));
      |            ~~~~~~~~~~^~~~
/home/dale/git/overte/overte-master/interface/src/avatar/MyAvatar.cpp: In member function ‘void MyAvatar::FollowHelper::activate(CharacterController::FollowType, bool)’:
/home/dale/git/overte/overte-master/interface/src/avatar/MyAvatar.cpp:5779:22: warning: comparison is always true due to limited range of data type [-Wtype-limits]
 5779 |     assert((int)type >= 0 && (int)type < static_cast<int>(CharacterController::FollowType::Count));
      |            ~~~~~~~~~~^~~~
/home/dale/git/overte/overte-master/interface/src/avatar/MyAvatar.cpp: In member function ‘bool MyAvatar::FollowHelper::isActive(CharacterController::FollowType) const’:
/home/dale/git/overte/overte-master/interface/src/avatar/MyAvatar.cpp:5786:22: warning: comparison is always true due to limited range of data type [-Wtype-limits]
 5786 |     assert((int)type >= 0 && (int)type < static_cast<int>(CharacterController::FollowType::Count));
      |            ~~~~~~~~~~^~~~
HifiExperiments commented 2 weeks ago

damn, I was only looking at the github actions which build release mode, sorry about that