search

overte-org / overte

Overte open source virtual worlds platform.
https://overte.org/
Other
128 stars 47 forks source link

Ambient Light Color #1043

Closed HifiExperiments closed 3 days ago

HifiExperiments commented 1 week ago

Closes #6

Adds ambientLight.ambientColor to Zone Entities, matching the behavior of skybox.color.

Funding

This project is funded through NGI0 Entrust, a fund established by NLnet with financial support from the European Commission's Next Generation Internet program. Learn more at the NLnet project page.

NLnet foundation logo NGI Zero Logo

ksuprynowicz commented 1 week ago

I just tested on Linux, and all works well, including values persisting when restarting server and client.

ksuprynowicz commented 1 week ago

Oops... I didn't test it well enough. It looks like it has exactly same but as unlit PR, with Create App misreporting property: image

HifiExperiments commented 1 week ago

huh...I wonder what I could have broken that would cause only new properties like these to report incorrectly!

ksuprynowicz commented 1 week ago

Another thing I noticed is that the property in Create App keeps the value of the last set color, so for example on the screenshot I created cyan-colored zone, and then red-colored zone. On the screenshot cyan zone is selected, but color is misreported as red: image

HifiExperiments commented 1 week ago

@ksuprynowicz fixed! adding new entity properties suuuuuucks. I have a few more new properties that I'm working on, and then I have an plan now of how to greatly simplify the whole process.

ksuprynowicz commented 1 week ago

Nice! I just tested it and everything works perfectly now :)