search

overte-org / overte

Overte open source virtual worlds platform.
https://overte.org/
Other
151 stars 51 forks source link

disable-displays and disable-inputs arguments broken #800

Open JulianGro opened 10 months ago

JulianGro commented 10 months ago

On latest master, both the disable-displays and the disable-inputs arguments display an "Unknown options" error. These arguments work fine on the latest stable version.

$ ./interface/interface --disable-displays "OpenVR (Vive)" --disable-inputs "SDL2","OpenVR (Vive)" --allowMultipleInstances
Interface: Unknown options: disable-displays, disable-inputs.
$
daleglass commented 10 months ago

Those got renamed to disableDisplayPlugins and disableInputPlugins (because that's what it does, disabling a plugin)

SilverfishVR commented 10 months ago

https://docs.overte.org/en/latest/developer/interface/command-line-parameters.html?highlight=command should be updated then

JulianGro commented 10 months ago

I feel like we should have the old argument print a message that it got renamed then. I will put it in the changelog before the next release, but at least disable-displays is pretty commonly used because of issues with OpenVR and/or Oculus Runtime, so people will run into the case of using old arguments.

I am also generally not sure if Overte should more or less silently fail when a command line argument is wrong. Currently, if you have an invalid command line argument, Overte will just not start. A Windows user that has edited their desktop shortcut to disable OpenVR is going to sit there waiting for Overte to start when it has already failed. The average user won't know how to run it in terminal either.