search

overte-org / overte

Overte open source virtual worlds platform.
https://overte.org/
Other
138 stars 50 forks source link

Dampening property of Flow reversed #809

Open JulianGro opened 8 months ago

JulianGro commented 8 months ago

Due to a bug in the code, increasing the dampening actually decreases dampening; It is reversed. While I don't remember what we decided on back when it was discovered, I just realized that we can fix the issue without breaking existing assets.

We can fix it in the flow code, and just reverse the value when read from an FST file, and when generated by the flow app. Adding a warning to the output of the flow app, and logging an info message when reading from FST. I think we all agree on FST files, the way that they are now, being replaced eventually. Meaning that we would not forever carry this legacy behaviour around with us (at least not outside of an FST reader).

This way, the sliders in the flow app start to make sense, and interactions with flow outside of FST files will be as expected. A future JSON based FST, glTF property, or whatever, would then not be required to use carry around this legacy behaviour.

daleglass commented 7 months ago

Do we need backwards compatibility for this one?

daleglass commented 7 months ago

New JSON format should have a version number. This way we can check that for future backwards compatibility fixes.

JulianGro commented 7 months ago

Do we need backwards compatibility for this one?

Well, it is a breaking change, so any avatar that uses it will have its dampening flipped.