search

overte-org / overte

Overte open source virtual worlds platform.
https://overte.org/
Other
138 stars 50 forks source link

Web Entity wantsKeyboardFocus #814

Closed HifiExperiments closed 7 months ago

HifiExperiments commented 7 months ago

https://github.com/overte-org/overte/issues/692

Funding

This project is funded through NGI0 Entrust, a fund established by NLnet with financial support from the European Commission's Next Generation Internet program. Learn more at the NLnet project page.

NLnet foundation logo NGI Zero Logo

JulianGro commented 7 months ago

This is a protocol break, right?

gydence commented 7 months ago

@JulianGro yep, this is targeting the protocol_change branch, which also has mirrors and tags. several of the other PRs I’m working on will also be protocol bumps, and then we can merge this branch to master whenever we decide to do the next RC

JulianGro commented 7 months ago

The server tag should make it build some server packages that can be used for testing.

ksuprynowicz commented 7 months ago

I just tested it, and I noticed two problems. The Wants Keyboard Focus property seems to reset to enabled soon after disabling it. Also Focus Highlight and Wants Keyboard Focus seem to be coupled in some way and sometimes I can't disable Wants Keyboard Focus in Create App at all.

HifiExperiments commented 7 months ago

@ksuprynowicz ugh I'm sorry, I had a copy-paste error that would affect this in non-serverless. should be fixed now

ksuprynowicz commented 7 months ago

I wonder why it wouldn't work correctly when I tested it? Setting seemed to reset to true on its own and sometimes even couldn't be set to false.

JulianGro commented 7 months ago

@ksuprynowicz, on my end, it takes a while for the changes to actually save. The way I worked around this is by leaving the server running for 10 minutes and then restarting it. If I restart it closely after making a change, said change will disappear.

ksuprynowicz commented 7 months ago

The weird thing though was that I was not restarting the server at all. The setting was resetting to true while server was running, and on the same client session without leaving and rejoining. It worked for a few seconds and then would spontaneously revert, and on some occassions was just stuck on true without possibility to switch it to false.

JulianGro commented 7 months ago

@ksuprynowicz, I didn't notice this before, but it looks like HifiExperiments tried fixing this exact issue in 7941c9e. Did you retry since then?

ksuprynowicz commented 7 months ago

Thanks! I missed his message I will build and test it again in a moment :)

ksuprynowicz commented 7 months ago

I tested again and it works perfectly now :) I think this PR is ready for merging into protocol change branch