overte-org / overte

Overte open source virtual worlds platform.
https://overte.org/
Other
132 stars 47 forks source link

Cast shadow property for local lights #843

Closed ksuprynowicz closed 4 months ago

ksuprynowicz commented 4 months ago

We still won't have local light shadows for some time but soon we plan to change the protocol, so maybe add this change too?

HifiExperiments commented 4 months ago

I'd vote to wait until we actually implement the feature. I don't love having unused properties cluttering things up, plus the create side would have to wait until later anyways.

the exact API might be more complicated than just a single bool, also. e.g. we might want "shadow groups" where certain lights only cast shadows for certain objects or something like that, or the shadow properties might need to be configurable (like shadow bias is currently on the keylight)

ksuprynowicz commented 4 months ago

I agree. We should wait until it's actually implemented.