search

overte-org / overte

Overte open source virtual worlds platform.
https://overte.org/
Other
132 stars 47 forks source link

Potentially duplicate FileDiolog.qml #848

Open Armored-Dragon opened 4 months ago

Armored-Dragon commented 4 months ago

This issue is opened at the request of some users in the hub for discussion. There are some files which look to be largely, but not entirely, duplicate qml files.

I've been doing testing on trying to see if I could replace the internal file picker and use the system's file picker. It seems like these files are used somewhere.

Maybe these could be condensed?

https://github.com/overte-org/overte/blob/9b89b3ffd9fe8bd9bd417f5a950b094aa807e577/interface/resources/qml/dialogs/FileDialog.qml

https://github.com/overte-org/overte/blob/9b89b3ffd9fe8bd9bd417f5a950b094aa807e577/interface/resources/qml/dialogs/TabletFileDialog.qml

https://github.com/overte-org/overte/blob/9b89b3ffd9fe8bd9bd417f5a950b094aa807e577/interface/resources/qml/hifi/tablet/tabletWindows/TabletFileDialog.qml

Armored-Dragon commented 3 months ago

This will likely be addressed with PR #886