Fix invalid animation reference in assignment client

overte-org / overte

Overte open source virtual worlds platform.

https://overte.org/

Other

138 stars 50 forks source link

Fix invalid animation reference in assignment client #854

Closed ksuprynowicz closed 6 months ago

ksuprynowicz commented 7 months ago

Possibly fixes assignment client (agent) animations. Fixes https://github.com/overte-org/overte/issues/852

ksuprynowicz commented 7 months ago

The PR started on wrong branch and I'm not sure how to fix it

ksuprynowicz commented 7 months ago

It's ready for CR and QA now

ksuprynowicz commented 7 months ago

For testing this creating agent client script with animated avatar would be needed. Animations in agent scripts don't seem to work in current version, so hopefully this fixes them.

ksuprynowicz commented 6 months ago

After testing it turned out that the code was crashing and animations were still not playing. Newest version fixes this and also fixes https://github.com/overte-org/overte/issues/720 Right now it works well when animation armature matches exactly avatar armature. Fixes for not matching armatures will come in next PR.

ksuprynowicz commented 6 months ago

Due to a lot of changes this will need one more review