overte-org / overte

Overte open source virtual worlds platform.
https://overte.org/
Other
128 stars 47 forks source link

Problems with HifiControlsUit.SpinBox #921

Open HifiExperiments opened 2 months ago

HifiExperiments commented 2 months ago

See #899

If you give a SpinBox a realFrom but no realTo, it will break. In that PR, I was setting realFrom to 1 and the spinbox would default to 1 (instead of its value), and trying to change the value would make it go to 0.

Additionally, it seemed like a SpinBox fires an onRealValueChanged before Component.onCompleted with the incorrect value of 1, regardless of the default value (and then maybe later a correct onRealValueChanged?). I had to work around that by introducing a local loaded property.