search

overte-org / overte

Overte open source virtual worlds platform.
https://overte.org/
Other
128 stars 47 forks source link

Warnings as errors #938

Open HifiExperiments opened 2 months ago

HifiExperiments commented 2 months ago

Closes #930

this is currently against the protocol_changes branch because one of the errors is in AudioMixer.cpp (from a recent PR of mine). I've only tried this on windows so I need to see if this works on linux.

Funding

This project is funded through NGI0 Entrust, a fund established by NLnet with financial support from the European Commission's Next Generation Internet program. Learn more at the NLnet project page.

NLnet foundation logo NGI Zero Logo

HifiExperiments commented 2 months ago

this one's failing with some kind of cmake error, but my changes to cmake were very minor...

daleglass commented 2 months ago

this one's failing with some kind of cmake error, but my changes to cmake were very minor...

It's failing in glslang, it's possible the warnings as errors setting is being applied to a dependency that's building with warnings?

HifiExperiments commented 2 months ago

ah that makes sense. should we pass a different set of flags to dependencies? or just only set this flag later?

daleglass commented 2 months ago

I think setting it later might work?