Import d69910a875: Fixed some GCC warnings and Qt deprecations (by Maki)

[daleglass]

This is an automated proposal to look at a commit made by Maki and import it into Overte

Commit:	d69910a875a5558c6b013c4bd52fc86df150716a
Author:	Maki
Date:	Sat, 25 Apr 2020 18:37

Fixed some GCC warnings and Qt deprecations

Stats:

Filename	Stats	Lines	Added	Removed	Lines in blame
domain-server/src/DomainServer.cpp		2	1	1	1
interface/src/Application.cpp		12	7	5	7
interface/src/Bookmarks.cpp		3	2	1	2
interface/src/avatar/AvatarDoctor.cpp		2	1	1	1
interface/src/ui/HMDToolsDialog.cpp		22	10	12	10
interface/src/ui/HMDToolsDialog.h		2	1	1	1
interface/src/ui/OctreeStatsDialog.cpp		1	1	0	⚠ 0
interface/src/ui/overlays/TextOverlay.cpp		2	1	1	1
libraries/avatars-renderer/src/avatars-renderer/Head.cpp		2	1	1	1
libraries/entities-renderer/src/EntityTreeRenderer.cpp		53	26	27	8
libraries/entities-renderer/src/RenderableEntityItem.cpp		2	1	1	⚠ 0
libraries/entities-renderer/src/RenderableEntityItem.h		1	0	1	⚠ 0
libraries/entities-renderer/src/RenderableImageEntityItem.cpp		2	1	1	1
libraries/entities-renderer/src/RenderableLightEntityItem.cpp		2	1	1	1
libraries/entities-renderer/src/RenderableLineEntityItem.cpp		2	1	1	1
libraries/entities-renderer/src/RenderableParticleEffectEntityItem.cpp		2	1	1	1
libraries/entities-renderer/src/RenderablePolyVoxEntityItem.cpp		2	1	1	1
libraries/entities-renderer/src/RenderableShapeEntityItem.cpp		2	1	1	⚠ 0
libraries/entities-renderer/src/RenderableTextEntityItem.cpp		2	1	1	1
libraries/entities-renderer/src/RenderableWebEntityItem.cpp		2	1	1	1
libraries/entities/src/EntityPriorityPropertyGroup.cpp		12	5	7	⚠ 0
libraries/entities/src/SimulationOwner.cpp		26	14	12	14
libraries/entities/src/SimulationOwner.h		1	1	0	1
libraries/entities/src/ZoneCullingPropertyGroup.cpp		12	6	6	⚠ 0
libraries/graphics-scripting/src/graphics-scripting/ScriptableMeshPart.cpp		23	13	10	13
libraries/render-utils/src/RenderPipelines.cpp		1	1	0	1
libraries/script-engine/src/ScriptEngine.cpp		2	1	1	1
tools/vhacd-util/src/VHACDUtil.cpp		2	1	1	1
28 files	-	199	102	97	70

To work on this, please assign the issue to yourself, then look at the commit and decide whether this would be a good addition to Overte.

• If the commit is useful, tag it with "Tivoli: Keep", and keep it open until it's merged.
• If the commit is not useful, tag it with "Tivoli: Discard", and close it.
• If the commit is not useful right now, but might be later, tag it with "Tivoli: Maybe later", and close it.
• If it's hard to decide, tag it with "Tivoli: Discuss", and keep it open.

Useful commits should be submitted as a PR against Overte. Tag this issue in PR, so that it's automatically closed once the PR is merged.

You can cherry-pick this issue with this command:

git cherry-pick d69910a875a5558c6b013c4bd52fc86df150716a

[daleglass]

already fixed