overthesun / simoc-web

This is the web interface to SIMOC
https://ngs.simoc.space/
Other
3 stars 0 forks source link

Agent Editor broken with Vue3 Update #105

Closed granawkins closed 3 years ago

granawkins commented 3 years ago

It seems this.$set isn't supported by Vue3, so some code will need to be replaced.

ezio-melotti commented 3 years ago

These have been removed, see https://v3.vuejs.org/guide/migration/introduction.html#removed-apis I already fixed one in https://github.com/ezio-melotti/simoc-web/commit/8f92d0cd69bf0acffd81e635453f925ce7885afc#diff-4eaf4f166c3e27f7f67d45b4bb03c9018cb972b217ed8db4f82285343981507b but there might be others that I missed. As far as I understand it should be enough to replace this.$set(obj, 'prop', value) with obj.prop = value and this.$delete(obj, 'prop') with delete obj.prop. If that doesn't work, there is also a reactive() function that can be used explicitly, but afaiu it's already applied to variables declared in data (and maybe to the props too).