overthesun / simoc-web

This is the web interface to SIMOC
https://ngs.simoc.space/
Other
3 stars 0 forks source link

Wrong SVG <path>s in the logo #605

Closed ezio-melotti closed 6 months ago

ezio-melotti commented 6 months ago

The logo at https://github.com/overthesun/simoc-web/blob/master/src/assets/simoc-logo.svg has 3 <path>s that outline the 3 leaves that intersect the blue area on the left. These paths are set to be white (#ffffff), and while this works on a white background, it doesn't on a dark one: https://github.com/overthesun/simoc-web/blob/eb51ccaa79c5a2e8bbce84cf94bafc373665f1d3/src/assets/simoc-logo.svg#L132-L136

This is how it looks on a dark background: image

I tried to change to opacity to make them transparent, but they end up showing the blue underneath instead: image

I think the best approach would be to cut the blue part to go around the leaves, and removes these white paths.

GregRRoss commented 6 months ago

White parts around leaves subtracted using path "difference" : https://github.com/overthesun/simoc-web/pull/608

ezio-melotti commented 6 months ago

Before: image After: image Fixed!