search

overthesun / simoc-web

This is the web interface to SIMOC
https://ngs.simoc.space/
Other
3 stars 0 forks source link

Fix browser reported entry field issues #735

Closed GregRRoss closed 1 month ago

GregRRoss commented 1 month ago

While I was looking to improve code on my ACE branch and fix "issues" reported by the browser, I cam across these issues from our login page and it looked like an easy fix.

When you attempt to login to SIMOC and look at the browser console, there are issues the browser reports related to the lack of an id or name for each form <input> element.

This screenshot shows how the issue is presented in Chrome: b4_fix

I added an "id" for each of these fields, as well as 'autocomplete="on"' for the username field, which eliminates all browser reported 'issues' related to the login form, and additionally should make it so that browsers can more reliably use autocomplete for a return user for their username field.

This screenshot shows issues no longer present on the login screeen in Chrome:

field_id_fix

GregRRoss commented 1 month ago

I have implemented the suggested consistency changes, and tested to see if autocomplete fills in the form with the guest ID. On Chrome I am not seeing any autocomplete behavior for the guest login, however in Edge I get autocomplete both the original master branch and also this branch. In FireFox, the original branch and also this branch causes the browser to ask if you want to save the guest login username and password.

It does not appear that the behavior is changed on browsers for the guest login with the autocomplete='on' but it does eliminate the browser 'issue' from being reported.