overthesun / simoc

A scalable model of an interactive, off-world community
https://ngs.simoc.space/
GNU General Public License v3.0
2 stars 2 forks source link

Confusing plant growth in `abm-redesign` #173

Open ezio-melotti opened 2 years ago

ezio-melotti commented 2 years ago

We noticed that with both the SAM preset and with the abm-redesign branch code, the Greenhouse Plant Growth panel shows the same growth percentage for all the plants. With the SAM preset there is some slight divergence after 70% growth, but all plants are harvested at step 2040.

granawkins commented 2 years ago

This is correct. The lifetime for all of them (in agent_desc) is 2040 hours, so their growth should be the same.

If it diverges slightly, it's because of the co2 level and the order in which their step functions are called.

On Sun, Feb 6, 2022 at 1:37 AM Ezio Melotti @.***> wrote:

Assigned #173 https://github.com/overthesun/simoc/issues/173 to @granawkins https://github.com/granawkins.

— Reply to this email directly, view it on GitHub https://github.com/overthesun/simoc/issues/173#event-6014148831, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL7VFK5HEGNRALOWEFKEPLDUZVU7LANCNFSM5NUJFQ5A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were assigned.Message ID: @.***>

kstaats commented 2 years ago

Grant,

This is correct. The lifetime for all of them (in agent_desc) is 2040 hours, so their growth should be the same.

If it diverges slightly, it's because of the co2 level and the order in which their step functions are called.

I did not catch that :)

Rice: 85 days
Cabbage: 85 days
Tomato: 85 days
Sweet Potato: 85 days

Very clever!

We need to update the SIMOC website to include and describe this preset.

https://simoc.space/simoc/presets/

Could you take a first stab at a quick desc of this, and why you selected four foods with the same growth period?

Thanks! kai

On Sun, Feb 6, 2022 at 1:37 AM Ezio Melotti @.***> wrote:

Assigned #173 https://github.com/overthesun/simoc/issues/173 to @granawkins https://github.com/granawkins.

— Reply to this email directly, view it on GitHub https://github.com/overthesun/simoc/issues/173#event-6014148831, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL7VFK5HEGNRALOWEFKEPLDUZVU7LANCNFSM5NUJFQ5A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were assigned.Message ID: @.***>