search

overthesun / simoc

A scalable model of an interactive, off-world community
https://ngs.simoc.space/
GNU General Public License v3.0
2 stars 1 forks source link

Update socketio dependency versions #443

Closed ezio-melotti closed 9 months ago

ezio-melotti commented 9 months ago

This is a follow-up of:

In this PR I'll try to bump the versions of the 3 socketio-related packages to pinpoint where the issues were introduced. The dependencies are:

ezio-melotti commented 9 months ago

This is a summary of my tests:

flask_socketio python-socketio python-engineio OK?
5.3.2 5.8.0 4.6.1 :heavy_check_mark:
5.3.6 5.8.0 4.6.1 :heavy_check_mark:
5.3.6 5.8.0 4.7.0 :heavy_check_mark:
5.3.6 5.9.0 4.7.0 :heavy_check_mark:
5.3.6 5.9.0 4.7.1 :x:
5.3.6 5.9.0 4.8.0 :x:
5.3.6 5.10.0 4.8.0 :x:
5.3.6 5.10.0 4.7.0 :boom:

The issue seems to be with python-engineio>=4.7.1. python-socketio==5.10.0 depends on python-engineio>=4.8.0, so the last test (with python-engineio>=4.7.0) failed.

ezio-melotti commented 9 months ago

I'm going to merge this with the following versions:

flask_socketio==5.3.6
python-socketio==5.9.0
python-engineio==4.7.0

These are:

The actual issue has been apparently introduced in https://github.com/miguelgrinberg/python-engineio/commit/614f564275c635dc8b03d33dab44bf80d280cbcc.

See also the following issue for more discussions on this: