overthesun / simoc

A scalable model of an interactive, off-world community
https://ngs.simoc.space/
GNU General Public License v3.0
2 stars 2 forks source link

Indiscriminate plant harvesting #97

Open ezio-melotti opened 5 years ago

ezio-melotti commented 5 years ago

After updating the plant growth panel to use the agent_growth data, I noticed something unusual. It seems that e.g. the radish is harvested every 600h even if it's nor ready to be harvested (because it skipped some steps due to lack of power/light).

Request to /new_game to reproduce it:

{"game_config":{
  "duration":{"type":"day","value":100},
  "human_agent":{"amount":4},
  "food_storage":{"amount":10000},
  "solar_pv_array_mars":{"amount":30},
  "power_storage":{"amount":1},
  "eclss":{"amount":1},
  "single_agent":1,
  "plants":[
    {"species":"wheat","amount":50},
    {"species":"cabbage","amount":50},
    {"species":"strawberry","amount":50},
    {"species":"radish","amount":50},
    {"species":"red_beet","amount":33}, 
    {"species":"lettuce","amount":34}
  ],
  "greenhouse":"greenhouse_small",
  "habitat":"crew_habitat_small"
}}

With these values the radish reached 61.275% at step 599, 33.79% at step 1199 27.8977% at step 1799, 31.1962% at step 2399 and then dropped to 0 at the next step (presumably because it got harvested). The batteries run out around step ~450, so the radish skips some steps due to lack of power/light (thus not reaching 100% at the end of a 600 steps period).

I also noticed that the edible food from the greenhouse in the nutrient storage 1 sits at 0kg throughout the duration of the simulation.

ezio-melotti commented 1 year ago

I believe this is the intended behavior. @granawkins can you confirm?

granawkins commented 1 year ago

Confirmed