search

overtone / at-at

Ahead-of-time function scheduler
Eclipse Public License 1.0
292 stars 38 forks source link

Remove (almost) all reflection calls #3

Closed jjcomer closed 11 years ago

jjcomer commented 11 years ago

I removed all the reflection calls, except for the call to .cancel.

samaaron commented 11 years ago

Interesting - were you perceiving any specific performance issues?

jjcomer commented 11 years ago

More of a pre-emptive strike. I was looking into using at-at in performance sensitive context, where there are going to be lots scheduled events (which have to be scheduled quickly).

samaaron commented 11 years ago

Typically, I'm against adding type metadata where there isn't a specific performance issue to be resolved. However, as it looks like this lib is fairly static in terms of the API it's probably no big deal.