search

overtone / emacs-live

M-x start-hacking
http://overtone.github.com/emacs-live/
Other
1.52k stars 241 forks source link

Fix auto swtich to ruby-mode on .rake, .gemspec and Gemfile #105

Closed dparis closed 11 years ago

dparis commented 11 years ago

Looks like this got fixed in master before and then the changes got lost. Just a hunch, but I suspect when @samaaron merged @balinterdi's initial PR, he didn't realize the changes were only in the live pack directory and not the dev pack as well, thus clobbering the fix when the update-live-packs script was run.

This PR applies the same change as @balinterdi's original commit to both the dev and the live packs.

Cheers!

samaaron commented 11 years ago

If you can update this request to only modify the dev packs, then I'll be happy to consider merging it. I reserve updates to the live directory as a way of making releases. (Clearly I shouldn't have accepted the earlier pull request!)

TrevorS commented 11 years ago

Pull request #116 fixes this issue, I believe it can be closed.

samaaron commented 11 years ago

OK, great, I'll close up. Feel free to re-open if you think it needs addressing again :-)