search

overtone / emacs-live

M-x start-hacking
http://overtone.github.com/emacs-live/
Other
1.51k stars 242 forks source link

doc-string face changed with font-lock-doc-face in cyberpunk theme #185

Closed practicalli-johnny closed 9 years ago

practicalli-johnny commented 9 years ago

The doc-string face for Clojure / elisp was changed using font-lock-doc-face rather than font-lock-doc-string-face in the cyberpunk theme. This gives the clojure / elisp doc strings their own face characteristics (italic DarkOrange).

font-lock-doc-string-face does not change the face characteristics of doc-string for elisp or clojure. However, changing the theme to use font-lock-doc-face does change the characteristics of the doc-string face. This change does not affect comments, strings or help text.

Here is a screenshot of the change:

emacs-live-theme-cyberpunk-doc-string-face-fix

If this is not the correct way to fix the theme, please point me in the right direction.

samaaron commented 9 years ago

Good call, although I'm not sure if I actually like it in orange. I'll have a play around :-)

practicalli-johnny commented 9 years ago

I am not fixed to the orange myself, it stuck with the colour you had already for doc string. I do like it as italic and would be happier with a more subtle colour for the text.​ If I find more appropriate colours I'll let you know.

practicalli-johnny commented 9 years ago

I tried a couple of shades of yellow that seem quite nice:

FFE685

emacs-live-cyberpunk-doc-string-ffe685-highlight

Or slightly more subtle #FFE0A0

emacs-live-cyberpunk-doc-string-ffe0a0-highlight

practicalli-johnny commented 9 years ago

With 4b87e24, @samaaron has gone with a different choice of colour for the doc-string, so this pull request is redundant.

I will use #F0E0A0 forthe doc-string colour in my own version of the cyberpunk theme, defined in my live-pack.

practicalli-johnny commented 9 years ago

Hi overtone/emacs-live,

I'd like to add you to my professional network on LinkedIn.

Confirm that you know John: https://www.linkedin.com/e/v2?e=0-ig6sygit-60&t=ssuw&tracking=eml-guest-invite-cta&ek=invite_guest&sharedKey=209buiwx&invitationId=6064103160186748928

You received an invitation to connect. LinkedIn will use your email address to make suggestions to our members in features like People You May Know. Unsubscribe here: https://www.linkedin.com/e/v2?e=0-ig6sygit-60&t=lun&midToken=AQFmrFVhGEd36Q&ek=invite_guest&loid=AQGQW1HoMFfXgQAAAVCgF5X-6rpVzqJH6P-0a8R15AdE5LyY05VVBSOhVWH7rnELFWW4j8i0U1KUPUGTNRk1LChp09LqdPrzjG-1CZjkDWCL6_tkoULxvyHu3bhV1cvXroVtf01VQnbCIhIIC8PkFyG2AMV5cl5VmR4Ty6jX3JYI90GrF4GjVHkjECRjfBPVGA1G&eid=0-ig6sygit-60

This email was sent to reply@reply.github.com.

If you need assistance or have questions, please contact LinkedIn Customer Service: https://www.linkedin.com/e/v2?e=0-ig6sygit-60&a=customerServiceUrl&ek=invite_guest

© 2015 LinkedIn Corporation, 2029 Stierlin Court, Mountain View CA 94043. LinkedIn and the LinkedIn logo are registered trademarks of LinkedIn.

practicalli-johnny commented 9 years ago

John Stevenson would like to connect on LinkedIn. How would you like to respond?

Accept: https://www.linkedin.com/e/v2?e=c621ey-igbypqtl-5c&a=preRegInvite&ek=first_guest_reminder_01&li=8&m=hero&ts=accept_text&sharedKey=209buiwx&invitationID=6064103160186748928

View John Stevenson's profile: https://www.linkedin.com/comm/profile/view?id=AAsAAADuFZQBBFHC_4t4r8fV9QnfpH0jZ3KXcS4&trk=eml-first_guest_reminder_01-hero-9-profile_text&trkEmail=eml-first_guest_reminder_01-hero-9-profile_text-null-c621ey%7Eigbypqtl%7E5c

You received an invitation to connect. LinkedIn will use your email address to make suggestions to our members in features like People You May Know. Unsubscribe here: https://www.linkedin.com/e/v2?e=c621ey-igbypqtl-5c&t=lun&midToken=AQFmrFVhGEd36Q&ek=first_guest_reminder_01&li=12&m=unsub&ts=HTML&eid=c621ey-igbypqtl-5c&loid=AQE1eaqehDM0PQAAAVCzfWuEnX2CLbQ3pvG91yM0oAkh9UxzGqzg4H4kLfinBKz3naK2wNN5kJLy0orTJhq-rDcRi9q4j-DqYhg8VPINya_EO7aJA7H8dXNsj0p0k8YrzeAcOxu72sBn-0qjUqZ_u9oIB6pJiqBzWP9iUrLgbt-I6qiwpWd4juq8lxdKpbvjxt3b

This email was sent to reply@reply.github.com.

If you need assistance or have questions, please contact LinkedIn Customer Service: https://www.linkedin.com/e/v2?e=c621ey-igbypqtl-5c&a=customerServiceUrl&ek=first_guest_reminder_01

© 2015 LinkedIn Corporation, 2029 Stierlin Court, Mountain View CA 94043. LinkedIn and the LinkedIn logo are registered trademarks of LinkedIn.

bleadof commented 9 years ago

I love this :heart: Automation gone so wrong. :-D

practicalli-johnny commented 9 years ago

John Stevenson would like to connect on LinkedIn. How would you like to respond?

Accept: https://www.linkedin.com/e/v2?e=c621ey-iglysd4a-3w&a=preRegInvite&ek=second_guest_reminder_01&li=12&m=hero&ts=accept_text&sharedKey=209buiwx&invitationID=6064103160186748928

View John Stevenson's profile: https://www.linkedin.com/comm/profile/view?id=AAsAAADuFZQBBFHC_4t4r8fV9QnfpH0jZ3KXcS4&trk=eml-second_guest_reminder_01-hero-13-profile_text&trkEmail=eml-second_guest_reminder_01-hero-13-profile_text-null-c621ey%7Eiglysd4a%7E3w

You received an invitation to connect. LinkedIn will use your email address to make suggestions to our members in features like People You May Know. Unsubscribe here: https://www.linkedin.com/e/v2?e=c621ey-iglysd4a-3w&t=lun&midToken=AQFmrFVhGEd36Q&ek=second_guest_reminder_01&li=15&m=unsub&ts=HTML&eid=c621ey-iglysd4a-3w&loid=AQFMwWO6lsLDcQAAAVDXhhZorcNGTCKY1dPLRhegSkPnGwvvyJgrqMBwEONvlD_hT9ORMvJ5Na1IV2hN2ySrI0iVyCmFIKiTdlTY5T1EfTJjePmTaRokpg6rbF09gLJVcXkARASq5bUMsDtKIgXELBKuYv1LrOZNeS6zAJAVKspK7gD12ZoXEmShMFW0nBiUgdaA

This email was sent to reply@reply.github.com.

If you need assistance or have questions, please contact LinkedIn Customer Service: https://www.linkedin.com/e/v2?e=c621ey-iglysd4a-3w&a=customerServiceUrl&ek=second_guest_reminder_01

© 2015 LinkedIn Corporation, 2029 Stierlin Court, Mountain View CA 94043. LinkedIn and the LinkedIn logo are registered trademarks of LinkedIn.