overtone / emacs-live

M-x start-hacking
http://overtone.github.com/emacs-live/
Other
1.51k stars 241 forks source link

Hard coding clojure-mode for cljs will cause problems #228

Open arichiardi opened 8 years ago

arichiardi commented 8 years ago

I have had this problem while updating cider to 0.11.0 (you can see that I am keeping up with the updates, but not maintaining publicly this here) because of the following line:

https://github.com/overtone/emacs-live/blob/7983bc7561ea05d7432e03cc616fbfadafdf241b/packs/dev/clojure-pack/config/clojure-conf.el#L58-L59

The two lines will need to be removed, I can provide a patch when Emacs Live moves to 0.11.0 as well.

samaaron commented 8 years ago

Please do provide a patch :-)

arichiardi commented 8 years ago

Of course, but it does not make sense now, I will wait the bump to 0.11.0

arichiardi commented 8 years ago

Ah you mean a patch for 0.11.0? I was thinking about it, will try to find time ok?

Malabarba commented 8 years ago

For the record, there's no reason to wait for cider 0.11.0 (which is already out anyway, btw). Clojure-mode has had a clojurescript-mode for a while now, and that's what people should be using for clojurescript files.

arichiardi commented 8 years ago

For the record, I did not know :smile: I will patch!

Malabarba commented 8 years ago

:wink: :+1:

arichiardi commented 8 years ago

Done, and btw @samaaron in the process of upgrading the clojure-pack, clj-refactor had some additional modules to add, I think I worked already on this here so feel free to have a look at:

I know I should rebase to align myself to master but I think I will do when emacs-live switches to cider 0.11.0 :D