search

overtone / emacs-live

M-x start-hacking
http://overtone.github.com/emacs-live/
Other
1.51k stars 241 forks source link

haskell-mode error: symbol definition is void: haskell-mode-contextual-space #233

Closed urbanslug closed 8 years ago

urbanslug commented 8 years ago

outdated version of haskell-mode.

When using the current version of emacs-live and press the spacebar I get an error: symbol definition is void: haskell-mode-contextual-space

This is similar to the one experienced in this spacemacs issue https://github.com/syl20bnr/spacemacs/issues/227 and there are two fixes for this.

  1. A quick way is to add '(require haskell) to lang-pack/config/haskell-conf.el however as explained in that https://github.com/syl20bnr/spacemacs/issues/227 an update in haskell-mode fixed it (this to be specific https://github.com/haskell/haskell-mode/issues/392).
  2. Updating haskell-mode is therefore the better fix. In the newer versions of haskell-mode haskell-simple-indent was removed (see https://github.com/haskell/haskell-mode/wiki/Month-in-Haskell-Mode-October-2015#heads-up-cruft-removal) so the requirement in line 3 of lang-pack/config/haskell-conf.el shall also be removed.

Let me know if anyone has any objections to this. I will make the update on packs/stable/ and use the git version of haskell-mode which requires Emacs 23.x and above which should be okay with emacs-live.

edit: I wish to be assigned this issue because I have a ready fix.

samaaron commented 8 years ago

Hi, thanks for looking into this.

I'm happy to consider pull requests for the dev packs but not stable. Stable packs are only updated as part of a release cycle (and one is due soon).

I've currently updated most of the libs locally and am working on fixing broken/missing deps. I should have a new release of Emacs Live within a week or so.

urbanslug commented 8 years ago

Okay, I will send in a PR for the dev pack. I assume you will move the fix from dev to stable yourself (you haven't explicitly stated this) in about a week, right?

samaaron commented 8 years ago

I've already updated to the latest Haskell version locally. Would your pull request do more than this?

I'll update to stable manually when I'm happy with everything. Hopefully in around a week but maybe more depending on other commitments.

Sent from my iPhone

On 29 Mar 2016, at 09:26, Njagi Mwaniki notifications@github.com wrote:

Okay, I will send in a PR for the dev pack. I assume you will move the fix from dev to stable yourself (you haven't explicitly stated this) in about a week, right?

— You are receiving this because you commented. Reply to this email directly or view it on GitHub

urbanslug commented 8 years ago

Nothing more, just remove (require 'haskell-simple-indent) from haskell-conf.el as explained earlier. Thank you for acting on it so quickly.

urbanslug commented 8 years ago

Still getting this error.

edit Oh I see, you made the change in the dev pack not the stable. But when there's a breakage in stable shouldn't it get an update?