search

overtone / emacs-live

M-x start-hacking
http://overtone.github.com/emacs-live/
Other
1.51k stars 242 forks source link

Fix #2: screenshot display in README.md file #239

Closed valera-rozuvan closed 8 years ago

valera-rozuvan commented 8 years ago

It appears that recent changes to GitHub don't allow for referencing to GitHub hosted images from within Markdown files. If you look at the JS Console Log on the page https://github.com/overtone/emacs-live , you will see:

emacs-live:1 Refused to load the image 'http://github.com/downloads/overtone/emacs-live/emacs-live.png' because it violates the following Content Security Policy directive: "img-src 'self' data: assets-cdn.github.com identicons.github.com www.google-analytics.com collector.githubapp.com *.gravatar.com *.wp.com *.githubusercontent.com".

emacs-live:1 Refused to load the image 'https://cloud.github.com/downloads/overtone/live-coding-emacs/live-coding-config-in-use.png' because it violates the following Content Security Policy directive: "img-src 'self' data: assets-cdn.github.com identicons.github.com www.google-analytics.com collector.githubapp.com *.gravatar.com *.wp.com *.githubusercontent.com".

emacs-live:1 Refused to load the image 'https://cloud.github.com/downloads/overtone/live-coding-emacs/live-coding-config-in-use-2.png' because it violates the following Content Security Policy directive: "img-src 'self' data: assets-cdn.github.com identicons.github.com www.google-analytics.com collector.githubapp.com *.gravatar.com *.wp.com *.githubusercontent.com".

So I am proposing to move the screenshots to the repository. You can see that this actually works over at my cloned repo: https://github.com/valera-rozuvan/emacs-live .

valera-rozuvan commented 8 years ago

@samaaron https://github.com/overtone/emacs-live/pull/238 didn't actually help = ) This one should do the trick!

samaaron commented 8 years ago

Super!