search

overtone / emacs-live

M-x start-hacking
http://overtone.github.com/emacs-live/
Other
1.52k stars 242 forks source link

File saving (save-buffer) broken in Emacs 25.1.1 #250

Open cassiel opened 8 years ago

cassiel commented 8 years ago

I'm getting this, and can't save files. I see the issue fix about money-patching save-buffer: I pulled the latest version and still have this problem.

screenshot 2016-10-05 09 57 40

cassiel commented 8 years ago

All seems fine in Emacs 24.x.

dupuchba commented 8 years ago

same here for 25.x trying with the 24.x version (mac os X)

samaaron commented 8 years ago

This has been fixed on master: https://github.com/overtone/emacs-live/commit/4a86f13c9f8deffec3e459de693a81437abc2a32

piotr-yuxuan commented 8 years ago

Hello,

Thanks for emacs-live, it's been a pleasure to use it! However, I'm reporting the very same save error. I've cloned / pulled this repo and my local (untouched) ~/.emacs.d is on commit 4a86f13. I use Emacs 25.3.50 (9.0) on macOS Sierra.

I may have missed a part but it seems the bug is still here despite of the bug.

cassiel commented 8 years ago

Problem not fixed in the stable packs, I guess. Switching to the dev packs, both Emacs 24 and 25 break (can't find swiper?). screenshot 2016-10-13 21 21 47

necsoft commented 8 years ago

+1

samaaron commented 8 years ago

Sorry - I have fixed this locally - and will push it up to master and make a release tomorrow :-)

samaaron commented 8 years ago

I've just pushed out release B24 - could you update to see if it fixes your issue? :-)

cassiel commented 8 years ago

Will do (when I'm on my Sierra Beta machine later today). Is this fix in the dev packs or the standard ones?

cassiel commented 8 years ago

OK - seems happy now in Emacs 24.x and 25.x. I do get the following (although this seems benign):

WARNING: No org-loaddefs.el file could be found from where org.el is loaded. You need to run "make" or "make autoloads" from Org lisp directory

rothmichaels commented 8 years ago

OK - seems happy now in Emacs 24.x and 25.x. I do get the following (although this seems benign): WARNING: No org-loaddefs.el file could be found from where org.el is loaded. You need to run "make" or "make autoloads" from Org lisp directory

This error has been logging for a long time, and is benign. org-loaddefs.el is loaded in org-pack/init.el so by the time (require 'org) is called and org-mode reports this area, (provide 'org-loaddefs) has already been done.

I have never investigated the difference between the included org-loaddefs.el and what would be generated if I ran make locally, but I have had no issues with org-mode since #243.