search

overtone / emacs-live

M-x start-hacking
http://overtone.github.com/emacs-live/
Other
1.52k stars 242 forks source link

Tweak Gandalf theme. #76

Closed namin closed 11 years ago

namin commented 11 years ago

The foreground yellow Markdown link face inherited from Cyberpunk is unreadable on a white background.

The suggestion here is just to make it a background instead of foreground color -- though we could also pick a new alternative color?

samaaron commented 11 years ago

Thanks for this. I rarely use the Gandalf theme - it was built for those occasions you want to do a presentation on a low contrast projector. It's good to have people playing with it and finding the rough edges such as this :-)

samaaron commented 11 years ago

Although for future pull requests, could you only include changes to the dev packs. That way I can package the updates for standard users into more manageable versions.

namin commented 11 years ago

Sure, good to know for the future. Sorry about that. I wasn't sure where I should do the change so followed the precedence of https://github.com/overtone/emacs-live/pull/33/files

samaaron commented 11 years ago

Ah, good point - I should have followed up there too :-)

Thanks for your work anyway!