search

overtools / OWLib

Toolchain that lets you interact with the Overwatch files and extract models and stuff.
MIT License
361 stars 40 forks source link

effects model name should use GetNameIndex #165

Closed evie404 closed 2 years ago

evie404 commented 2 years ago

other places all use modelInfo.GetNameIndex()

https://github.com/overtools/OWLib/blob/ab08a937c236c0eb313cb6616e439c9125398b3b/DataTool/SaveLogic/Combo.cs#L350

https://github.com/overtools/OWLib/blob/ab08a937c236c0eb313cb6616e439c9125398b3b/DataTool/SaveLogic/Effect.cs#L74

Js41637 commented 2 years ago

I mean, all the code is crap tbf.

evie404 commented 2 years ago

all the code

you referring to effects or all the file path stuff? if the latter, i've been sitting on a bunch of commits that might make it easier. just never got around to making a PR cuz i'm forgetful :x

Js41637 commented 2 years ago

It's possible a lot of this code might have to be rewritten for OW2 anyway so I'm not sure if it's really worth looking these things at the moment.