search

overtrue / phplint

:bug: A tool that can speed up linting of php files by running several lint processes at once.
MIT License
984 stars 118 forks source link

[9.0.0] PHAR version not available #175

Closed llaville closed 1 year ago

llaville commented 1 year ago

Summary

Release workflow did not build the PHAR version of PHPLint 9.0.0 (https://github.com/overtrue/phplint/actions/runs/4162210510/jobs/7201105513)

Expected behaviour

PHAR built

Actual behaviour

PHAR version not available

llaville commented 1 year ago

@overtrue I've a permission denied https://github.com/overtrue/phplint/actions/runs/4164613643/jobs/7206478202#step:7:21 when create a new release (with release workflows). Could you check-in and give me your feedback please ?

PHAR build was fixed; It's on upload process !

overtrue commented 1 year ago

I just tried to re-run it and also reported the same error, the logs are as follows.

https://github.com/overtrue/phplint/actions/runs/4164613643/jobs/7206478202#step:7:21

Is it because the path to the .phar file is not the right value?

Build:

Building the PHAR "/github/workspace/bin/phplint.phar"

Publish:

Error: EACCES: permission denied, open '/home/runner/work/phplint/phplint/bin/phplint.phar'

llaville commented 1 year ago

@overtrue At the Build PHAR step inside line 10 (initialisation) we can find -v "/home/runner/work/phplint/phplint":"/github/workspace"

I'm convainced that the volume is propagated (because read-write by default) : https://docs.docker.com/storage/volumes/#populate-a-volume-using-a-container

But it should not be !

llaville commented 1 year ago

@overtrue I'll replace current https://github.com/overtrue/phplint/blob/9.0.2/.github/workflows/build-phar.yml workflow, by the new one https://github.com/overtrue/phplint/blob/main/.github/workflows/release.yml

PS: I've replaced my docker image that produce PHAR artifact in root mode, by invocation of the box-manifest PHAR version

Advantage:

github com_overtrue_phplint_releases_tag_untagged

release-workflow

NOTE The draft mode (checkbox on workflow dispatch dialog box) when enable allow a chance to preview/modify before publish it definitively !

llaville commented 1 year ago

FYI: I'll clean-up repository, due to all my tests in few minutes, and publish the new release 9.0.3

llaville commented 1 year ago

@overtrue FYI : I've played a bit with new workflow, but PHAR distribution is now available. I'll close this report, but I need to improve the new https://github.com/overtrue/phplint/blob/9.0.3/.github/workflows/release.yml for next release