Open b-f-chan opened 1 year ago
additionally: fix the lack of horizontal scrolling here
Initial browsing, found items:
NOTE: [From @b-f-chan] Confirmed with @samrichca this is a DMS-UI side change, not an Arranger change Note from Sam: Added to list of enhancements.
NOTE: [From @b-f-chan] @samrichca to follow-up with @edsu7 offline to show her; cannot currently reproduce, don't know which files were used Note from Sam: Talked to Edmund & Caroline, made a ticket. https://github.com/GMOD/jbrowse-components/issues/3823
1c855fe5-a46a-5c5b-a5a2-bf884d62b9b7 (12-22)
c47eeabe-3ce8-554f-8b81-c7870addad0c (15-22)
77f69d8a-9161-550d-b5e3-63a03237a2ad (6-22)
NOTE: [From @b-f-chan] @samrichca to reproduce with @edsu7 offline to check network tab and actual request; may need support from Caroline once troubleshooting info is available Note from Sam: Edmund & Caroline still troubleshooting.
683d8024-d3a1-5686-a12e-982fd6c82ba4
NOTE: [From @b-f-chan] Consensus among team is to list the offending files in the error message. However, if they pick too many files, we're going to disable J-Browse button and show a custom tooltip telling them they are over the limit. @patrickdsantos to provide verbiage.
[From @patrickdsantos] Copy for the tooltip: Too many files have been selected. A maximum of 5 files may be selected at once.
Note from Sam: Added to list of enhancements.
NOTE: [From @b-f-chan] Confirmed with @justincorrigible this is fixed on the Arranger side, so up to @samrichca to reimplement in DMS-UI
Note from Sam: Fixed in Arranger 31. DMS-UI has to be updated from 16 to 31 on QA.
QA Feedback
[From @b-f-chan] @justincorrigible believes this should already be fixed with latest Arranger, to be verified
NOTE: [From @b-f-chan] @samrichca to fix on DMS-UI side
NOTE: [From @b-f-chan] This occurs because J-Browse button can only make one request at a time, so if user clicks multiple rows quickly, there is a lag. There's different ways to handle this, for example using debounce, or throttle, or we can add a spinner/loader. This happens both when you click Select All and multiple rows in succession individually. However, this is an edge case, the Select All issue is more likely to occur. Some investigation into best approach required. This is low priority, and when we get to it, prioritize Select All.
[From @b-f-chan] Confirmed with @justincorrigible this requires an Arranger fix
[From @b-f-chan and @justincorrigible] This is expected behaviour in Arranger; however suggested enhancement is to add a hover-state where the X gets highlighted on hover as a visual cue. LOW PRIORITY - @justincorrigible @patrickdsantos to discuss offline how to approach it
[From @patrickdsantos] Please change the "x" hover state to #979797
[From @b-f-chan] Could not reproduce in real-time with the team. @patrickdsantos to try reproducing one last time, else we will park or close this.
[From @patrickdsantos ] Was able to reproduce. If a user selects a controlled file and an open file then deselects the open file and controlled file in that order, the JBrowse button remains available and the user is able to visualize "0 files". I have a recording of the bug for better understanding.
NOTE: [From @b-f-chan] Consensus among team is to list the offending files in the error message. However, if they pick too many files, we're going to disable J-Browse button and show a custom tooltip telling them they are over the limit. @patrickdsantos to provide verbiage.
[From @patrickdsantos] Copy for the tooltip: Too many files have been selected. A maximum of 5 files may be selected at once.
[From @patrickdsantos] Copy for the error message: 0 files have been selected. Please select 1-5 files to launch JBrowse.
@patrickdsantos - To provide a darker gray for the disabled button state to accommodate this
[From @patrickdsantos] Please change grey button to #5E6068 with white text. (Apply this change for all disabled buttons.)
Design Feedback
NOTE: This section is all LOW PRIORITY. To do only after all other feedback in this ticket are addressed.
[this is more finicky stuff that isn't a huge deal but is a nice thing to fix if there's time!]
Can we double the size of the "x" button on the JBrowse tab?
Increase the height of the title cell blocks to 6px in the original table
Remove spacing above first item in download list
[From @b-f-chan] To be investigated, likely DMS-UI issue, but @justincorrigible will confirm
[From @b-f-chan] @justincorrigible believes this should already be fixed with latest Arranger, to be verified
Update 08/10/2023: everything in this comment is completed
To do list for me
Cosmetic changes
Fixed in https://github.com/overture-stack/dms-ui/pull/170:
Additional ticket for selection logic & errors: https://github.com/overture-stack/dms-ui/issues/171
Updated the QA deployment with the following fixes:
Loader
position as per Patrick’s feedback, caused by outdated state handling; and now all Arranger components use the same DMS-UI loader (consistency).Still pending:
all completed except:
For the "freezing" of Arranger filters, a workaround could be operating as a "modal". Without using a "window", but instead by applying an overlay that blocks interactions outside the jBrowse area, it would accomplish the intended result. Also, shouldn't be terribly difficult to implement, methinks.
I'm coming from the perspective that Arranger is designed to manage internally the functionalities it offers e.g. filters, and while blocking them could be a useful new feature for internal usage, this request seems more like a jBrowse concern.
Thoughts?
Mega ticket for all feedback from QA - Can be split into smaller tickets if required.
Some initial feedback from June 8, 2023 demo included - @samrichca to add screenshots from local for this since QA environment not ready yet.
======= Feedback from June 8, 2023 Demo =======
FOR MVP:
X files not supported
, not just some filesPost MVP:
======= Feedback from QA: =======