overture-stack / ego

OAuth 2.0 authorization service that supports multiple OpenID identity providers
https://www.overture.bio/products/ego
GNU Affero General Public License v3.0
25 stars 14 forks source link

Cleanup unused configs and stale code #461

Open rtisma opened 4 years ago

rtisma commented 4 years ago

After briefly looking at the application.yml (config file) for ego, some configs were found to be stale/not-used anywhere in the code.

For example jwt.secret https://github.com/overture-stack/ego/blob/3.0.0/src/main/resources/application.yml#L4-L5

There are probably alot more, that are not needed, and its should be cleaned up, becuase it was confusing while updating a the helm chart for ego.

rosibaj commented 3 years ago

@andricDu is this still valid?