overture-stack / iobio-components

0 stars 1 forks source link

:atom: Feat/11 React Components #24

Closed demariadaniel closed 3 months ago

demariadaniel commented 3 months ago
ciaranschutte commented 3 months ago

<div key={key} className="row iobio-chart-container"> this should be in the react component it's the boundary for the webcomponent wrapper. if you miss putting it in the charts grow exponentially.

demariadaniel commented 3 months ago

<div key={key} className="row iobio-chart-container"> this should be in the react component it's the boundary for the webcomponent wrapper. if you miss putting it in the charts grow exponentially.

This is true, the web components need to be in a container with explicit height. My thinking was that dimensions and usage will change depending on consumer app. See that I've mapped 5 PercentBoxes in one parent but each Histogram is its own row.