overture-stack / lectern

Data Schema / Dictionary management system
GNU Affero General Public License v3.0
0 stars 2 forks source link

Feature Request: Allow scripts on integer and number #133

Closed rosibaj closed 3 years ago

rosibaj commented 3 years ago

Looking at the metaschema, lectern currently will not accept a schema/dictionary that has restriction.script for valueType number orinteger because its metaschema doesn't allow it: image

However, because integerRestrictions doesn't have additionalProperties: false, default must be true which allowed submitting integer with script restriction which in itself is a bug. @hknahal and @rosibaj have been able to submit integer scripts based on this bug.

Expected Behaviour

hknahal commented 3 years ago

Tested updates using dictionary version 102.3 on QA. Was able to successfully migrate dictionary where the pack_years_smoked field is associated with a script. Details regarding validation in PR https://github.com/icgc-argo/argo-dictionary/pull/294

rosibaj commented 3 years ago

@Buwujiu can i please get a version on this ticket?

rosibaj commented 3 years ago

confirmed on migration to dictionary 1.10