Open UmmulkiramR opened 10 months ago
merged to develop
@UmmulkiramR
I tested both data submission and download in cumulus rdpc-qa for small datasets using score version 5.10.0
without providing profile, and both succeeded. I used subworkflow in argo-modules to test both:
nextflow run ./tests/subworkflows/icgc-argo-workflows/song_score_upload -entry test_song_score_upload_user -profile docker -c ./tests/config/nextflow.config --api_token *** --study_id TEST-PR --payload ./tests/data/qa/payload.sequencing_experiment.json --upload_files "./tests/data/qa/test_rg_3*.v2.bam" --song_url "https://submission-song.rdpc-qa.cumulus.genomeinformatics.org" --score_url "https://submission-score.rdpc-qa.cumulus.genomeinformatics.org" --song_container_version "5.0.2" --score_container_version "5.10.0" --song_container "ghcr.io/overture-stack/song-client" --score_container "ghcr.io/overture-stack/score"
nextflow run ./tests/subworkflows/icgc-argo-workflows/song_score_download -entry test_song_score_download_user -profile docker -c ./tests/config/nextflow.config --api_token *** --study_id TEST-QA --analysis_id 2c392294-7a1c-4de8-b922-947a1c1de803 --song_url "https://song.rdpc-qa.cumulus.genomeinformatics.org" --score_url "https://score.rdpc-qa.cumulus.genomeinformatics.org" --song_container_version "5.0.2" --score_container_version "5.10.0" --song_container "ghcr.io/overture-stack/song-client" --score_container "ghcr.io/overture-stack/score"
Deployed on prod
At the moment, score-client and score-server each operate on a storage profile (azure or s3), and they need to be synced to make sure the correct object storage system is called. If not in sync the uploads/downloads will fail. Users, however, should not have to worry about operating score-client on the right profile. Hence, this change is proposed where score-client will auto-sync itself with the profile of score-server.
As part of this change,
_getStorageProfiles_
) will be added to score-server that returns the active profiles it is operating on._getStorageProfiles_
endpoint to get the active profiles._getStorageProfiles_
endpoint score-client will use the existing logic to select the right profile which is defaulting to S3 storage.