In the current PR, we have done refactoring to the code in order to eliminate the icgc.dependency imports. These imports are being replaced with imports from an alternative library, bio.overture.score.core
The reason for this change is that there are no more published versions of the dcc packages available. This means that the code can no longer rely on the org.icgc.dcc
The refactored code imports the function from the bio.overture.score class instead. This ensures that the code will continue to function correctly.
Also, This commit removes several test dependencies related to the org.icgc.dcc libraries:
These dependencies were previously included for testing purposes.
Reasoning:
Since the dcc dependency has also been removed , these test dependencies are no longer necessary.
Keeping unused dependencies can clutter the project's pom.xml file and potentially lead to issues during compilation or testing.
Moreover, we have Removed incomplete modern auth rule tests
This commit removes the following test files from the score-test module:
AbstractStorageIntegrationTest.java
PartitionedBucketFallbackIntegrationTest.java
PartitionedBucketIntegrationTest.java
StorageIntegrationTest.java
As, these tests were identified as incomplete for verifying the functionality of modern authentication rules. They likely did not cover all the necessary scenarios to ensure proper access control based on these rules. Also we have migrated the utils classes which were in libraries and used in the project
In the current PR, we have done refactoring to the code in order to eliminate the icgc.dependency imports. These imports are being replaced with imports from an alternative library, bio.overture.score.core
The reason for this change is that there are no more published versions of the dcc packages available. This means that the code can no longer rely on the org.icgc.dcc
The refactored code imports the function from the bio.overture.score class instead. This ensures that the code will continue to function correctly.
Also, This commit removes several test dependencies related to the org.icgc.dcc libraries:
dcc-auth-server dcc-common-core dcc-metadata-core dcc-metadata-client dcc-metadata-server
These dependencies were previously included for testing purposes.
Reasoning:
Moreover, we have Removed incomplete modern auth rule tests
This commit removes the following test files from the score-test module:
As, these tests were identified as incomplete for verifying the functionality of modern authentication rules. They likely did not cover all the necessary scenarios to ensure proper access control based on these rules. Also we have migrated the utils classes which were in libraries and used in the project