search

overture-stack / score

Secure Cloud Object REsource: file transfer microservice
https://www.overture.bio/products/score
GNU Affero General Public License v3.0
18 stars 10 forks source link

Remove ICGC References - score-fs name and type #420

Closed joneubank closed 1 month ago

joneubank commented 2 months ago

Summary of request

Remove ICGC references from Score-FS SotrageFile Store. There are hardcoded strings to name the FS with icgc, we can instead name this after score

Details

https://github.com/overture-stack/score/blob/f931ebe0a6e1f4f0976acd14d578ef09149f1eee/score-fs/src/main/java/bio/overture/score/fs/StorageFileStore.java#L27

Rename this as SCORE_FS with the value "scorefs"

https://github.com/overture-stack/score/blob/f931ebe0a6e1f4f0976acd14d578ef09149f1eee/score-fs/src/main/java/bio/overture/score/fs/StorageFileStore.java#L31

Name can be "score"

Additional context

Check for any references to a StorageFileStore name or type. This is eventually used by the score-client. We need to be sure there is no specific reference to these properties that will require additional logic changes.

joneubank commented 2 months ago

Let's also update the name string while making this change: https://github.com/overture-stack/score/blob/f931ebe0a6e1f4f0976acd14d578ef09149f1eee/score-fs/src/main/java/bio/overture/score/fs/StorageFileStore.java#L45-L47