overture-stack / score

Secure Cloud Object REsource: file transfer microservice
https://www.overture.bio/products/score
GNU Affero General Public License v3.0
18 stars 10 forks source link

Remove ICGC References - StorageFileSystems use `icgc://` scheme #421

Closed joneubank closed 1 month ago

joneubank commented 2 months ago

Summary of request

Remove icgc reference in StorageFileSystems. This is used as the "scheme" for the FileSystem URI. This seems like an arbitrary string value, but I am not aware of how it is used or what value it needs to have.

Details

https://github.com/overture-stack/score/blob/f931ebe0a6e1f4f0976acd14d578ef09149f1eee/score-fs/src/main/java/bio/overture/score/fs/StorageFileSystems.java#L41 https://github.com/overture-stack/score/blob/f931ebe0a6e1f4f0976acd14d578ef09149f1eee/score-fs/src/main/java/bio/overture/score/fs/StorageFileSystemProvider.java#L73

We should be able to use the value score and score:// in place of icgc.

Additional context

Before proposing changes, please find an explanation of what the java.nio FileSystem URI is used for and why such an arbitrary scheme is allowed. Right now I am not clear about what the impact of this change will be.